Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new selector for retry #6351

Merged
merged 9 commits into from
Dec 3, 2024
Merged

add new selector for retry #6351

merged 9 commits into from
Dec 3, 2024

Conversation

bnjjj
Copy link
Contributor

@bnjjj bnjjj commented Nov 27, 2024

apollo_router_http_request_retry_total metric is now deprecated and will be removed in the next major router version (2.0). Here is the new configuration to migrate to a new metric called http.client.request.retry which is now an histogram and you can configure it using custom instrumentation.

telemetry:
  exporters:
    metrics:
      common:
        views:
        - name: apollo_router_http_request_retry_total # Drop the deprecated metric
          aggregation: drop
        - name: http.client.request.retry # Set the right buckets for the new metric
          aggregation:
            histogram:
              buckets:
                - 1
                - 10
                - 100
                - 1000
  instrumentation:
    instruments:
      subgraph:
        http.client.request.retry: # Create custom histogram measuring the number of retries for http request to a subgraph
          type: histogram
          value:
            subgraph_resend_count: true
          unit: hit
          description: histogram of subgraph request resend count
          condition:
            gt:
            - subgraph_resend_count: true
            - 0
          attributes:
            subgraph.name: true
            supergraph.operation.name:
              supergraph_operation_name: string

Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Tests added and passing3
    • Unit Tests
    • Integration Tests
    • Manual Tests

Exceptions

Note any exceptions here

Notes

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

@svc-apollo-docs
Copy link
Collaborator

svc-apollo-docs commented Nov 27, 2024

✅ Docs Preview Ready

No new or changed pages found.

@router-perf
Copy link

router-perf bot commented Nov 27, 2024

CI performance tests

  • connectors-const - Connectors stress test that runs with a constant number of users
  • const - Basic stress test that runs with a constant number of users
  • demand-control-instrumented - A copy of the step test, but with demand control monitoring and metrics enabled
  • demand-control-uninstrumented - A copy of the step test, but with demand control monitoring enabled
  • enhanced-signature - Enhanced signature enabled
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • events_big_cap_high_rate_callback - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity using callback mode
  • events_callback - Stress test for events with a lot of users and deduplication ENABLED in callback mode
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • events_without_dedup_callback - Stress test for events with a lot of users and deduplication DISABLED using callback mode
  • extended-reference-mode - Extended reference mode enabled
  • large-request - Stress test with a 1 MB request payload
  • no-tracing - Basic stress test, no tracing
  • reload - Reload test over a long period of time at a constant rate of users
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • step-local-metrics - Field stats that are generated from the router rather than FTV1
  • step-with-prometheus - A copy of the step test with the Prometheus metrics exporter enabled
  • step - Basic stress test that steps up the number of users over time
  • xlarge-request - Stress test with 10 MB request payload
  • xxlarge-request - Stress test with 100 MB request payload

Signed-off-by: Benjamin <[email protected]>
Signed-off-by: Benjamin <[email protected]>
Signed-off-by: Benjamin <[email protected]>
@bnjjj bnjjj marked this pull request as ready for review November 28, 2024 13:49
@bnjjj bnjjj requested review from a team as code owners November 28, 2024 13:49
@bnjjj bnjjj enabled auto-merge (squash) December 3, 2024 10:46
@bnjjj bnjjj merged commit a9e83aa into dev Dec 3, 2024
13 checks passed
@bnjjj bnjjj deleted the bnjjj/new_retry_selector branch December 3, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants