-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove access_json
dependency and deprecated configurations
#6621
base: dev
Are you sure you want to change the base?
Conversation
Signed-off-by: Benjamin <[email protected]>
@bnjjj, please consider creating a changeset entry in |
CI performance tests
|
✅ Docs preview readyThe preview is ready to be viewed. View the preview File Changes 0 new, 1 changed, 0 removed
Build ID: f70396128e4aa52b2bec8c19 URL: https://www.apollographql.com/docs/deploy-preview/f70396128e4aa52b2bec8c19 |
Signed-off-by: Benjamin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the router fail to start if you use the old syntaxes? I assume yes but just checkin' :)
Maybe it'd be good to land the config validate
command for 2.0 and tell people to use that in the migration guide so they can spot issues with that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but I think we need to address the unwrap()
that I reference.
Signed-off-by: Benjamin <[email protected]>
@goto-bus-stop Actually I thought it would fail to select the right data without |
Signed-off-by: Benjamin <[email protected]>
Signed-off-by: Benjamin <[email protected]>
Remove
access_json
from our dependencies. It's no longer needed and has been replaced byjsonpath-rust
which follows the jsonpath specs.It removes the deprecated
subgraph_response_body
selector from telemetry configuration and change the type ofpath
field inheaders
configuration when you want to get a data from request body and insert it in a subgraph header.you'll have to migrate the
path
field to be jsonpath compliant and just add$
at the beginning of thepath
, example:subgraph_response_body
selector for telemetry like this:You'll have to migrate the
subgraph_response_body
tosubgraph_response_data
selector (orsubgraph_response_errors
if you want to target errors):Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
Note any exceptions here
Notes
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩