Removed deprecated methods for [email protected] #6646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* remove services::router::Response's `.map()` function * remove router::event::schema::SchemaSource::File's `delay` field * remove router::event::configuration::Configuration::File's `delay` field * remove context::extensions::sync::ExtensionMutex 's `.lock()` function
This comment has been minimized.
This comment has been minimized.
|
CI performance tests
|
✅ Docs preview readyThe preview is ready to be viewed. View the preview File Changes 0 new, 1 changed, 0 removedBuild ID: ed7c6f4af64579ce2edbc186 URL: https://www.apollographql.com/docs/deploy-preview/ed7c6f4af64579ce2edbc186 |
This is a less of a problem now that `.lock() -> ExtensionsGuard` is removed and only `.with_lock(impl FnOnce(ExtensionsGuard))` remains: the latter cannot keep the guard alive across `.await` This check was flaky on CI when CPUs are busy with lots of tests running in parallel.
Its only purpose left was to deref, so pass that reference directly instead
removes two unsupported methods in `PluginInit` interface: * `unsupported_supergraph_schema` * `unsupported_subgraph_schema`
…cument Removes `unsupported_executable_document` from public implementation of `Context` and replaces it with an internal `pub(crate) executable_document`
…hql/router into lrlna/2.0-deprecation
The following deprecated metrics have been removed: * apollo_router_deduplicated_subscriptions_total * apollo_authentication_failure_count * apollo_authentication_success_count * apollo_require_authentication_failure_count
The following initialisation functions have been removed: * PluginInit::new() * PluginInit::try_new()
lrlna
commented
Jan 27, 2025
Comment on lines
-272
to
+270
| pub fn unsupported_executable_document(&self) -> Option<Arc<Valid<ExecutableDocument>>> { | ||
| /// Read only access to the executable document for internal router plugins. | ||
| pub(crate) fn executable_document(&self) -> Option<Arc<Valid<ExecutableDocument>>> { |
There was a problem hiding this comment.
As talked about during the huddle this morning, this was changed to a pub(crate) to let us continue using this for router's own demand control plugin.
Comment on lines
-592
to
-597
| u64_counter!( | ||
| "apollo_authentication_failure_count", | ||
| "Number of requests with failed JWT authentication (deprecated)", | ||
| 1, | ||
| kind = "JWT" | ||
| ); |
There was a problem hiding this comment.
I removed several of these metrics that had deprecated notes. Let me know if this shouldn't happen.
lrlna
commented
Jan 27, 2025
SimonSapin
approved these changes
Jan 27, 2025
BrynCooke
reviewed
Jan 27, 2025
BrynCooke
requested changes
Jan 27, 2025
garypen
approved these changes
Jan 27, 2025
There was a problem hiding this comment.
I think you may have done: https://apollographql.atlassian.net/browse/ROUTER-297 as well (although, I'm not totally sure).
Thanks for the diligent cleanup. Nice to see so much code being deleted...
ooops didn't know there was a separate ticket for deprecated metrics. i don't know if i did actually remove the entire tracing macro system. @goto-bus-stop you are assigned to ROUTER-297, was there anything else that needed to be removed? should i just pause here and let you figure what needed to be done for that metrics layer clean up? |
It's the PluginInit::new() method that no longer exists.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following deprecated fields are being removed:
services::router::Response::map()router::event::schema::SchemaSource::File.delayfieldrouter::event::configuration::Configuration::File.delayfieldcontext::extensions::sync::ExtensionMutex::lock()test_harness::TestHarness::build()PluginInit::new()PluginInit::try_new()The following unsupported fields are being removed. Since they are "unsupported", I omitted them from the changeset and upgrade docs.
axum_factory::unsupported_set_axum_router_callbackPluginInit::unsupported_supergraph_schemaPluginInit::unsupported_subgraph_schemaContext::unsupported_executable_documentThe following deprecated metrics are being removed:
apollo_require_authentication_failure_countapollo_authentication_failure_countapollo_authentication_success_countapollo_router_deduplicated_subscriptions_totalAdditionally, the callback of context::extensions::sync::ExtensionMutex 's
.with_lock()function now receives&mut Extensionsinstead of a guard that dereferences to it. This makes amutbinding no longer necessary for the callback argument.