feat: add install-chromedriver command #366

KazuCocoa · 2024-10-21T05:44:24Z

Let's add the same automatic download (latest one) which is removed from appium-chromedriver.

This command will give the below log's ability.

kazu $ appium driver run chromium install-chromedriver
WARN Appium Appium encountered 1 warning while validating drivers found in manifest /Users/kazu/github/appium-chromium-driver/node_modules/.cache/appium/extensions.yaml
WARN Appium Driver "chromium" has 1 potential problem: 
WARN Appium   - Driver "chromium" (package `appium-chromium-driver`) may be incompatible with the current version of Appium (v2.6.0) due to its peer dependency on Appium ^2.11.5. Please install a compatible version of the driver.
dbug ChromedriverGoogleapisStorageClient Parsed 776 entries from storage XML
info ChromedriverGoogleapisStorageClient The total count of entries in the mapping: 546
info ChromedriverChromelabsStorageClient The total count of entries in the mapping: 4975
dbug ChromedriverStorageClient Selecting chromedrivers whose versions match to 130.0.6723.58
dbug ChromedriverStorageClient Got 5 items
dbug ChromedriverStorageClient Selecting chromedrivers whose platform matches to mac:arm64
dbug ChromedriverStorageClient Got 1 item
dbug ChromedriverStorageClient Excluding older patches if present
dbug ChromedriverStorageClient Versions mapping: {
dbug ChromedriverStorageClient   "130": [
dbug ChromedriverStorageClient     "130.0.6723.58"
dbug ChromedriverStorageClient   ]
dbug ChromedriverStorageClient }
dbug ChromedriverStorageClient Got 1 driver to sync: [
dbug ChromedriverStorageClient   "130.0.6723.58/chromedriver-mac-arm64.zip"
dbug ChromedriverStorageClient ]
dbug ChromedriverStorageClient Retrieving 'https://storage.googleapis.com/chrome-for-testing-public/130.0.6723.58/mac-arm64/chromedriver-mac-arm64.zip' to '/var/folders/l5/4djs4rts6dg8jxwjv45wkr_w0000gn/T/2024920-54661-1rq3y7o.td0k/0.zip'
dbug Support Traversed 2 directories and 3 files in 2ms
dbug ChromedriverStorageClient Moving the extracted 'chromedriver' to '/Users/kazu/github/appium-chromium-driver/node_modules/appium-chromedriver/chromedriver/mac/chromedriver-mac-arm64_v130.0.6723.58'
dbug ChromedriverStorageClient Permissions of the file '/Users/kazu/github/appium-chromium-driver/node_modules/appium-chromedriver/chromedriver/mac/chromedriver-mac-arm64_v130.0.6723.58' have been changed to 755
info ChromedriverStorageClient Successfully synchronized 1 chromedriver
✔ install-chromedriver successfully ran

kazu $ CHROMEDRIVER_VERSION=131.0.6778.3 appium driver run chromium install-chromedriver
WARN Appium Appium encountered 1 warning while validating drivers found in manifest /Users/kazu/github/appium-chromium-driver/node_modules/.cache/appium/extensions.yaml
WARN Appium Driver "chromium" has 1 potential problem: 
WARN Appium   - Driver "chromium" (package `appium-chromium-driver`) may be incompatible with the current version of Appium (v2.6.0) due to its peer dependency on Appium ^2.11.5. Please install a compatible version of the driver.
dbug ChromedriverGoogleapisStorageClient Parsed 776 entries from storage XML
info ChromedriverGoogleapisStorageClient The total count of entries in the mapping: 546
info ChromedriverChromelabsStorageClient The total count of entries in the mapping: 4975
dbug ChromedriverStorageClient Selecting chromedrivers whose versions match to 131.0.6778.3
dbug ChromedriverStorageClient Got 5 items
dbug ChromedriverStorageClient Selecting chromedrivers whose platform matches to mac:arm64
dbug ChromedriverStorageClient Got 1 item
dbug ChromedriverStorageClient Excluding older patches if present
dbug ChromedriverStorageClient Versions mapping: {
dbug ChromedriverStorageClient   "131": [
dbug ChromedriverStorageClient     "131.0.6778.3"
dbug ChromedriverStorageClient   ]
dbug ChromedriverStorageClient }
dbug ChromedriverStorageClient Got 1 driver to sync: [
dbug ChromedriverStorageClient   "131.0.6778.3/chromedriver-mac-arm64.zip"
dbug ChromedriverStorageClient ]
dbug ChromedriverStorageClient Retrieving 'https://storage.googleapis.com/chrome-for-testing-public/131.0.6778.3/mac-arm64/chromedriver-mac-arm64.zip' to '/var/folders/l5/4djs4rts6dg8jxwjv45wkr_w0000gn/T/2024920-54819-14lyp1m.o995/0.zip'
dbug Support Traversed 2 directories and 3 files in 1ms
dbug ChromedriverStorageClient Moving the extracted 'chromedriver' to '/Users/kazu/github/appium-chromium-driver/node_modules/appium-chromedriver/chromedriver/mac/chromedriver-mac-arm64_v131.0.6778.3'
dbug ChromedriverStorageClient Permissions of the file '/Users/kazu/github/appium-chromium-driver/node_modules/appium-chromedriver/chromedriver/mac/chromedriver-mac-arm64_v131.0.6778.3' have been changed to 755
info ChromedriverStorageClient Successfully synchronized 1 chromedriver
✔ install-chromedriver successfully ran
kazu $ ls /Users/kazu/github/appium-chromium-driver/node_modules/appium-chromedriver/chromedriver/mac/
chromedriver-mac-arm64_v130.0.6723.58 chromedriver-mac-arm64_v131.0.6778.3

#363

README.md

mykola-mokhnach · 2024-10-21T06:24:46Z

README.md

+[Chorme for testing](https://github.com/GoogleChromeLabs/chrome-for-testing)
+in `node_modules/appium-chromedriver/chromedriver` directory with `appium driver run chromium install-chromedriver`.
+
+As same as [appium-chromedriver](https://github.com/appium/appium-chromedriver),


not sure if it also would make sense to introduce command line arguments for the same

Do you mean giving CHROMEDRIVER_VERSION and CHROMELABS_URL would not be helpful? So, just gives appium driver run chromium install-chromedriver to download latest version?

it's fine to have env variables. I mean that maybe duplicating their functionality by adding --chromedriver-version and --chromelabs-url command line params it would be more convenient for end users.

README.md

mykola-mokhnach · 2024-10-21T06:25:27Z

package.json

@@ -33,7 +33,8 @@
    "README.md",
    "CHANGELOG.md",
    "LICENSE",
-    "npm-shrinkwrap.json"
+    "npm-shrinkwrap.json",
+    "scripts/*.mjs"


simply include the whole scripts dir

not sure if we also need to add this folder to the list of linted sources

Hm, I might miss somewhere. npx eslint scripts/install-chromedriver.mjs worked but npx eslint . ignored the scripts.

mykola-mokhnach · 2024-10-21T06:26:28Z

scripts/install-chromedriver.mjs

+        VERSION_LATEST;
+}
+
+async function formatCdVersion (ver) {


why cannot we import these functions and constants instead of duplicating them?

Do you mean exporting them from appium-chromedriver's index and import them from the module? No special reason but just to not modify the chromedriver side only for these usage in scripts. e.g. Move formatCdVersion from test to somewhere and exporting it.
Or importing them from appium-chromedriver/build/lib/constants...? Then, appium-chromedriver may not know if the path could be used by other modules (this package.) so probably not good to do it

there is no need to export from index. You may export directly from build/lib. See, for example, https://github.com/appium/appium-windows-driver/blob/dba67a91039f8919373e7e913f862c2b8dcda867/scripts/install-wad.mjs#L7

Yea, then you mean import LATEST from 'appium-chromedriver/build/lib/constants'; correct? Then, the https://github.com/appium/appium-chromedriver should keep the structure to not break https://github.com/appium/appium-chromium-driver (this module). I wanted to avoid calling other package's internal path such as build/lib... since it means https://github.com/appium/appium-chromedriver maintenance should keep taking care of https://github.com/appium/appium-chromium-driver

you may still call the script directly from node_modules in appium-chromium-driver. Although, I would consider either adding a separate script to the latter then. Same with uia2 driver

scripts/install-chromedriver.mjs

KazuCocoa · 2024-10-22T02:27:45Z

updated with the latest chromedriver

KazuCocoa added 3 commits October 20, 2024 22:12

feat: add install chromedriver command

8cc247e

run npm install

5cb0ec5

docs: add scripts

81a9efe

KazuCocoa requested review from jlipps and mykola-mokhnach October 21, 2024 05:45

tweak

8fcaf70

mykola-mokhnach reviewed Oct 21, 2024

View reviewed changes

README.md Outdated Show resolved Hide resolved

mykola-mokhnach reviewed Oct 21, 2024

View reviewed changes

README.md Outdated Show resolved Hide resolved

mykola-mokhnach reviewed Oct 21, 2024

View reviewed changes

scripts/install-chromedriver.mjs Outdated Show resolved Hide resolved

mykola-mokhnach reviewed Oct 21, 2024

View reviewed changes

scripts/install-chromedriver.mjs Outdated Show resolved Hide resolved

KazuCocoa added 9 commits October 21, 2024 00:05

docs: update readme

1ba5e79

remove .mjs

13089ac

tweak naming

720073a

simplify a bit

4871ef7

remove npm config

e095149

use appium-chromium-driver

da40e52

modify the readme

5d94b21

fix lint

b398e0e

use getLatestKnownGoodVersion

665767c

KazuCocoa marked this pull request as draft October 21, 2024 08:20

KazuCocoa commented Oct 21, 2024

View reviewed changes

scripts/install-chromedriver.mjs Show resolved Hide resolved

KazuCocoa added 3 commits October 21, 2024 19:21

use chrome driver 6.1.0

9cb4ad5

remove axios

543e486

tweak the package-lock

a566c94

KazuCocoa marked this pull request as ready for review October 22, 2024 02:27

KazuCocoa requested a review from mykola-mokhnach October 22, 2024 02:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add install-chromedriver command #366

feat: add install-chromedriver command #366

KazuCocoa commented Oct 21, 2024

mykola-mokhnach Oct 21, 2024

KazuCocoa Oct 21, 2024

mykola-mokhnach Oct 21, 2024 •

edited

Loading

mykola-mokhnach Oct 21, 2024

mykola-mokhnach Oct 21, 2024

KazuCocoa Oct 21, 2024

mykola-mokhnach Oct 21, 2024 •

edited

Loading

mykola-mokhnach Oct 21, 2024

KazuCocoa Oct 21, 2024

mykola-mokhnach Oct 21, 2024

KazuCocoa Oct 21, 2024

mykola-mokhnach Oct 21, 2024

KazuCocoa commented Oct 22, 2024

feat: add install-chromedriver command #366

Are you sure you want to change the base?

feat: add install-chromedriver command #366

Conversation

KazuCocoa commented Oct 21, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mykola-mokhnach Oct 21, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mykola-mokhnach Oct 21, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

KazuCocoa commented Oct 22, 2024

mykola-mokhnach Oct 21, 2024 •

edited

Loading

mykola-mokhnach Oct 21, 2024 •

edited

Loading