Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add @no_side_effects. #647

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add @no_side_effects. #647

wants to merge 1 commit into from

Conversation

apghml
Copy link
Contributor

@apghml apghml commented Aug 9, 2024

No description provided.

@apghml apghml enabled auto-merge August 9, 2024 21:04
@apghml apghml disabled auto-merge August 9, 2024 21:04
@ds-hwang
Copy link
Contributor

ds-hwang commented Nov 13, 2024 •
edited
Loading

It is similar to @nowrap? #797

@apghml
Copy link
Contributor Author

apghml commented Nov 13, 2024 •
edited
Loading

Yes, it's the same except that it checks whether the function has side effects and errors if so. I had previously done a different PR that actually added an exact @nowrap decorator, but Ruoming advocated against that functionality at the time, so it never got merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markblee markblee markblee approved these changes

@ruomingp ruomingp ruomingp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@apghml @ds-hwang @markblee @ruomingp