NIOTSELG: Provide EventLoopGroup.any() implementation #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weissi
commented
Dec 3, 2021
| @@ -187,21 +187,6 @@ class NIOTSListenerChannelTests: XCTestCase { | |||
| XCTAssertNoThrow(try channel.closeFuture.wait()) | |||
| } | |||
|
|
|||
| func testBindingChannelsOnShutdownEventLoopsFails() throws { | |||
There was a problem hiding this comment.
that wasn't actually a valid test. A shut down EL doesn't run anything...
weissi
commented
Dec 3, 2021
| @@ -647,21 +647,6 @@ class NIOTSConnectionChannelTests: XCTestCase { | |||
| XCTAssertNoThrow(try channel.close().wait()) | |||
| } | |||
|
|
|||
| func testConnectingChannelsOnShutdownEventLoopsFails() throws { | |||
There was a problem hiding this comment.
that wasn't actually a valid test. A shut down EL doesn't run anything...
Lukasa
reviewed
Dec 3, 2021
| @@ -21,7 +21,7 @@ let package = Package( | |||
| .library(name: "NIOTransportServices", targets: ["NIOTransportServices"]), | |||
| ], | |||
| dependencies: [ | |||
| .package(url: "https://github.com/apple/swift-nio.git", from: "2.32.0"), | |||
| .package(url: "https://github.com/apple/swift-nio.git", .branch("main")), | |||
There was a problem hiding this comment.
It might be easiest to just immediately write this with a prediction of the version we need (it'll be the minor after the version we currently ship). The CI will fail, but that's fine, when it ships we should just be able to land this.
| @@ -111,7 +128,18 @@ internal class NIOTSEventLoop: QoSEventLoop { | |||
|
|
|||
| public func execute(qos: DispatchQoS, _ task: @escaping () -> Void) { | |||
| // Ideally we'd not accept new work while closed. Sadly, that's not possible with the current APIs for this. | |||
| self.taskQueue.async(qos: qos, execute: task) | |||
| let taskQueue = self.taskQueueLock.withLock { | |||
There was a problem hiding this comment.
If we've got an on-event-loop fast-path, we should use it here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See apple/swift-nio#2003 for details.