Skip to content

Commit

Permalink
address comments and update pull_request.yml
Browse files Browse the repository at this point in the history
Signed-off-by: jason yang <[email protected]>
  • Loading branch information
JasonYangShadow committed Oct 17, 2024
1 parent d356f36 commit 19a4d40
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/pull_request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jobs:

- name: Install Sphinx
run: |
pip install --user --upgrade --upgrade-strategy eager setuptools sphinx sphinx-rtd-theme restructuredtext_lint rstcheck pygments m2r2
pip install --user --upgrade --upgrade-strategy eager docutils==0.16 setuptools sphinx sphinx-rtd-theme restructuredtext_lint rstcheck pygments m2r2
- name: Lint rst
run: |
Expand Down
12 changes: 6 additions & 6 deletions checkpoint.rst
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ the state of a variable on the server.
$ curl --http0.9 localhost:8888
request:1
We can see that request count value is ``1`` when this application is started
We can see that the request count value is ``1`` when this application is started
and accessed via curl. After making another call to the application, we can see that the request
count is ``2`` as expected.

Expand All @@ -171,7 +171,7 @@ count is ``2`` as expected.
$ curl --http0.9 localhost:8888
request:2
Now that request count variable on our server is in a new state, ``2``, we can use the
Now that the request count variable on our server is in a new state, ``2``, we can use the
``checkpoint instance`` command and reference the instance via the
``instance://`` URI format:

Expand Down Expand Up @@ -200,22 +200,22 @@ our application's state:
And now when we get access to the application again, the request count value is ``3`` as expected,
meaning that previous request count value is ``2``.
meaning that the previous request count value was ``2``.

.. code::
$ curl --http0.9 localhost:8888
$ request:3
We can repeat previous two steps, i.e. stop server instance and restart it via dmtcp to verify the restoration
of the value of request count.
We can repeat the previous two steps, i.e. stop the server instance and restart it via dmtcp to verify the restoration
of the value of the request count.

.. code::
$ {command} instance stop server
$ {command} instance start --dmtcp-restart example-checkpoint server.sif restarted-server 8888
Then access the application and see that request count value is restored as expected.
Then access the application and see that the request count value is restored as expected.

.. code::
Expand Down

0 comments on commit 19a4d40

Please sign in to comment.