Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add explanation for Machine Config Pool Management #52

Merged
merged 2 commits into from
Oct 11, 2022
Merged

Add explanation for Machine Config Pool Management #52

merged 2 commits into from
Oct 11, 2022

Conversation

glrf
Copy link
Contributor

@glrf glrf commented Oct 10, 2022 •
edited
Loading

This should properly explain the changes introduced in #50

Checklist

  • PR contains a single logical change (to build a better changelog).
  • Update the documentation.
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog.
  • Link this PR to related issues or PRs.

@glrf glrf added the documentation Improvements or additions to documentation label Oct 10, 2022
@glrf glrf self-assigned this Oct 10, 2022
@glrf glrf force-pushed the doc/machine-config-pool branch 3 times, most recently from a9e7b8c to 8c0f06d Compare October 11, 2022 09:47
@glrf glrf force-pushed the doc/machine-config-pool branch from 8c0f06d to 7dcfdee Compare October 11, 2022 09:48
@glrf glrf marked this pull request as ready for review October 11, 2022 09:50
@glrf glrf requested a review from a team October 11, 2022 09:50
simu
simu approved these changes Oct 11, 2022
View reviewed changes
Copy link
Member

@simu simu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, some suggestions inline.

@glrf glrf force-pushed the doc/machine-config-pool branch from fa650d6 to a4c84fc Compare October 11, 2022 11:28
@glrf glrf merged commit 1a1b897 into master Oct 11, 2022
@glrf glrf deleted the doc/machine-config-pool branch October 11, 2022 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simu simu simu approved these changes

Assignees

@glrf glrf

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glrf @simu