Merge pull request #5 from appuio/fix/inflight-race-condition

Fix race condition in ICMP pinger
appuio · Sep 12, 2022 · 4a17c9c · 4a17c9c
2 parents 0644abc + b7cf530
commit 4a17c9c
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/ping/pinger.go b/ping/pinger.go
@@ -164,10 +164,11 @@ func (p *pinger) ping() error {
 		return fmt.Errorf("Failed to marshal ICMP packet: %w", err)
 	}
 
+	p.inflight.Store(p.seq, sent)
 	if _, err := p.conn.WriteTo(msgB, &p.addr); err != nil {
+		p.inflight.Delete(p.seq)
 		return fmt.Errorf("Failed to send ICMP packet: %w", err)
 	}
-	p.inflight.Store(p.seq, sent)
 	p.seq = p.seq + 1
 	return nil
 }