-
Notifications
You must be signed in to change notification settings - Fork 2
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Decision: Upgrade Controller Custom Health Checks
- Loading branch information
Showing
2 changed files
with
45 additions
and
0 deletions.
There are no files selected for viewing
44 changes: 44 additions & 0 deletions
44
...s/ROOT/pages/explanations/decisions/upgrade-controller-custom-healthchecks.adoc
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
= Upgrade Controller Custom Health Checks | ||
|
||
== Problem | ||
|
||
Currently, our OpenShift upgrade controller doesn't support custom health checks. | ||
Only checking the ClusterVersion CRD is supported, which is not sufficient for all use cases. | ||
|
||
The current health check implementation can only fail jobs, but not skip them. | ||
We might want to skip jobs in some cases, for example, if there are maintenance blocking PDBs in place. | ||
|
||
=== Goals | ||
|
||
* We have a method of implementing custom health checks for the upgrade controller | ||
* We can skip jobs based on the health check results | ||
|
||
=== Non-Goals | ||
|
||
* TODO | ||
|
||
== Proposals | ||
|
||
=== 1a. Extend `UpgradeJobHooks`; track pod exit codes for skipping upgrades | ||
|
||
=== 1b. Extend `UpgradeJobHooks`; upgrade controller exposes API for skipping upgrades | ||
|
||
=== 1c. Extend `UpgradeJobHooks`, upgrade controller adds CRD for skipping upgrades | ||
|
||
=== 1c. Extend `UpgradeJobHooks`, upgrade controller adds subresource for skipping upgrades | ||
|
||
=== 2. Implement a new health check mechanism in the `UpgradeJob` CRD | ||
|
||
=== 3. Implement a new health check mechanism analogous to the `UpgradeJobHook` CRD | ||
|
||
== Decision | ||
|
||
TODO | ||
|
||
== Rationale | ||
|
||
TODO | ||
|
||
== References | ||
|
||
* TODO |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters