Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Rook Ceph MON replacement section #382

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Change Rook Ceph MON replacement section #382

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 28 additions & 15 deletions docs/modules/ROOT/partials/storage-ceph-remove-mon.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,29 +50,42 @@ kubectl --as=cluster-admin -n syn-rook-ceph-cluster patch cephcluster cluster --
}]'
----

. Cordon node(s) to {mon-operation}
+
[source,bash,subs="attributes+"]
----
for node in $(echo -n {mon-replace-list}); do
kubectl --as=cluster-admin cordon "${node}"
done
----
+
. For every id in `$MON_IDS` replace the MON pod
+
[source,bash]
[source,bash,subs="attributes+"]
----
mon_id=<MON_ID>
kubectl --as=cluster-admin -n syn-rook-ceph-cluster delete pod \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why didn't this work (anymore)? I'm not happy with replacing a simple step which should trigger the rook operator to do the right thing with a fully manual step that can cause massive chaos.

-l app=rook-ceph-mon,ceph_daemon_id="${mon_id}"

# Scale operator down
kubectl --as=cluster-admin syn-rook-ceph-operator scale deploy/rook-ceph-operator --replicas=0
storage_node=<STORAGE_NODE>

# Get name of storage node
kubectl -n syn-rook-ceph-cluster get po -l ceph_daemon_id="${mon_id}" -owide

# Remove MON to replace from ConfigMap
#
# data:
# csi-cluster-config-json: '[{"clusterID":"syn-rook-ceph-cluster","monitors":["194.182.183.35:6789","194.182.180.80:6789","194.182.181.220:6789"],"cephFS":{"netNamespaceFilePath":"","subvolumeGroup":"","kernelMountOptions":"","fuseMountOptions":""},"rbd":{"netNamespa ceFilePath":"","radosNamespace":""},"nfs":{"netNamespaceFilePath":""},"readAffinity":{"enabled":false,"crushLocationLabels":null},"namespace":""}]'
# data: h=194.182.183.35:6789,j=194.182.180.80:6789,i=194.182.181.220:6789
# mapping: '{"node":{"h":{"Name":"storage-efb1","Hostname":"storage-efb1","Address":"194.182.183.35"},"i":{"Name":"storage-8bb1","Hostname":"storage-8bb1","Address":"194.182.181.220"},"j":{"Name":"storage-a79d","Hostname":"storage-a79d","Address":"194.182.180.80"}}}'
kubectl --as=cluster-admin -n syn-rook-ceph-cluster edit cm rook-ceph-mon-endpoints
# data:
# csi-cluster-config-json: '[{"clusterID":"syn-rook-ceph-cluster","monitors":["194.182.180.80:6789","194.182.181.220:6789"],"cephFS":{"netNamespaceFilePath":"","subvolumeGroup":"","kernelMountOptions":"","fuseMountOptions":""},"rbd":{"netNamespa ceFilePath":"","radosNamespace":""},"nfs":{"netNamespaceFilePath":""},"readAffinity":{"enabled":false,"crushLocationLabels":null},"namespace":""}]'
# data: j=194.182.180.80:6789,i=194.182.181.220:6789
# mapping: '{"node":{"i":{"Name":"storage-8bb1","Hostname":"storage-8bb1","Address":"194.182.181.220"},"j":{"Name":"storage-a79d","Hostname":"storage-a79d","Address":"194.182.180.80"}}}'
Comment on lines +66 to +76
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we actually want to make this the process, this must be a kubectl patch and not a kubectl edit and hope no mistakes happen. Otherwise this must be a 4-eyes process.


# Scale operator up
kubectl --as=cluster-admin syn-rook-ceph-operator scale deploy/rook-ceph-operator --replicas=0

# Wait until new MON is scheduled
kubectl --as=cluster-admin -n syn-rook-ceph-cluster get pods -w
kubectl -n syn-rook-ceph-cluster get pods -l app=rook-ceph-mon -w

# Wait until the cluster has regained full quorum
kubectl --as=cluster-admin -n syn-rook-ceph-cluster exec -it deploy/rook-ceph-tools -- \
ceph status
kubectl --as=cluster-admin -n syn-rook-ceph-cluster exec -it deploy/rook-ceph-tools -- ceph status

# Cordon node of old MON
kubectl --as=cluster-admin cordon ${storage_node}

# Repeat for all other $MON_IDS
----
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.