Display all times in UTC, including in Chart.js #665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fancyremarker
force-pushed
the
fix-utc-times
branch
from
16936ba to
363cc2a
Compare
joeclayallday
approved these changes
Dec 23, 2023
neurosnap
added a commit
that referenced
this pull request
Jan 3, 2024
Since we need luxon for chart.js to format timezone dates properly, we might as well replace date-fns with luxon. References: #665
neurosnap
added a commit
that referenced
this pull request
Jan 3, 2024
Since we need luxon for chart.js to format timezone dates properly, we might as well replace date-fns with luxon. References: #665
neurosnap
added a commit
that referenced
this pull request
Jan 3, 2024
Since we need luxon for chart.js to format timezone dates properly, we might as well replace date-fns with luxon. References: #665
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@neurosnap : this required swapping out
chartjs-adapter-date-fnsand replacing it withchartjs-adapter-luxon, which also introduces a dependency onluxon. I don't love adding dependencies, but I believe that time zone support is a must for a date formatting library, so I think this is a better approach than implementing time zone support ourselves on top of a library.See: