3Fixed #85

CHANGELOG.md

@@ -1,5 +1,11 @@
 # Changelog
 
+## v1.3.18
+
+[2021-05-17]
+
+- Fixed issue #85
+
 ## v1.3.17
 
 [2021-03-26]

package.json

@@ -1,6 +1,6 @@
 {
   "name": "mongoose-paginate-v2",
-  "version": "1.3.17",
+  "version": "1.3.18",
   "description": "A cursor based custom pagination library for Mongoose with customizable labels.",
   "main": "dist/index.js",
   "scripts": {

src/index.js

@@ -76,8 +76,11 @@ function paginate(query, options, callback) {
     ...options.customLabels,
   };
 
-  const limit =
-    parseInt(options.limit, 10) > 0 ? parseInt(options.limit, 10) : 0;
+  let limit = defaultOptions.limit;
+
+  if (pagination) {
+    limit = parseInt(options.limit, 10) > 0 ? parseInt(options.limit, 10) : 0;
+  }
 
   const isCallbackSpecified = typeof callback === 'function';
   const findOptions = options.options;
@@ -113,6 +116,10 @@ function paginate(query, options, callback) {
     skip = offset;
   }
 
+  if (!pagination) {
+    page = 1;
+  }
+
   let countPromise;
 
   if (forceCountFn === true) {
@@ -232,9 +239,9 @@ function paginate(query, options, callback) {
 
       if (limit == 0) {
         meta[labelLimit] = 0;
-        meta[labelTotalPages] = null;
-        meta[labelPage] = null;
-        meta[labelPagingCounter] = null;
+        meta[labelTotalPages] = 1;
+        meta[labelPage] = 1;
+        meta[labelPagingCounter] = 1;
         meta[labelPrevPage] = null;
         meta[labelNextPage] = null;
         meta[labelHasPrevPage] = false;

tests/index.js

@@ -280,13 +280,13 @@ describe('mongoose-paginate', function () {
       expect(result.docs).to.have.length(0);
       expect(result.totalDocs).to.equal(12);
       expect(result.limit).to.equal(0);
-      expect(result.page).to.equal(null);
-      expect(result.pagingCounter).to.equal(null);
+      expect(result.page).to.equal(1);
+      expect(result.pagingCounter).to.equal(1);
       expect(result.hasPrevPage).to.equal(false);
       expect(result.hasNextPage).to.equal(false);
       expect(result.prevPage).to.equal(null);
       expect(result.nextPage).to.equal(null);
-      expect(result.totalPages).to.equal(null);
+      expect(result.totalPages).to.equal(1);
     });
   });
 
@@ -539,6 +539,33 @@ describe('mongoose-paginate', function () {
     );
   });
 
+  it('pagination=false, limit/page=undefined -> return all docs', function () {
+    var query = {
+      title: {
+        $in: [/Book/i],
+      },
+    };
+
+    var options = {
+      pagination: false,
+      page: undefined,
+      limit: undefined,
+    };
+
+    return Book.paginate(query, options).then((result) => {
+      expect(result.docs).to.have.length(100);
+      expect(result.totalDocs).to.equal(100);
+      expect(result.limit).to.equal(100);
+      expect(result.page).to.equal(1);
+      expect(result.pagingCounter).to.equal(1);
+      expect(result.hasPrevPage).to.equal(false);
+      expect(result.hasNextPage).to.equal(false);
+      expect(result.prevPage).to.equal(null);
+      expect(result.nextPage).to.equal(null);
+      expect(result.totalPages).to.equal(1);
+    });
+  });
+
   after(function (done) {
     mongoose.connection.db.dropDatabase(done);
   });