Add segment-segment intersection (2D only) #1207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalg24
reviewed
Feb 1, 2025
| auto const &a = segment.a; | ||
| auto const &b = segment.b; | ||
| return (p[0] >= min(a[0], b[0]) && p[0] <= max(a[0], b[0])) && | ||
| (p[1] >= min(a[1], b[1]) && p[1] <= max(a[1], b[1])); |
There was a problem hiding this comment.
Won't compile if the point coordinate type does match with the segment one?
Is that intentional? If so maybe add a static assert
There was a problem hiding this comment.
Why won't it compile when point coordinate does not match the segment one? The stuff inside min and max are coming from the segment, which means same types.
There was a problem hiding this comment.
FTAD will fail for Kokkos::min/max
dalg24
reviewed
Feb 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
segment.{_start,_end}tosegment.{a,b}