Remove requirement on knowing geometry types in IndexableGetter #1211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aprokop
commented
Feb 5, 2025
Comment on lines
+37
to
+38
| typename Enable = std::enable_if_t< | ||
| !Details::is_pair_value_index_v<std::decay_t<Geometry>>>> |
There was a problem hiding this comment.
This is needed so that universal reference does not grab PairValueIndex specializations.
dalg24
reviewed
Feb 5, 2025
| KOKKOS_FUNCTION Value operator()(PairValueIndex<Value, Index> &&pair) const | ||
| template <typename Geometry, typename Index> | ||
| KOKKOS_FUNCTION Geometry | ||
| operator()(PairValueIndex<Geometry, Index> &&pair) const | ||
| { | ||
| return pair.value; |
There was a problem hiding this comment.
Shouldn't we be moving it and returning a && here?
There was a problem hiding this comment.
I'm not sure why you are asking. We return a struct member. We don't need to do anything with the parent.
There was a problem hiding this comment.
I suppose we don't care since we get guaranteed copy elision?
Co-authored-by: Damien L-G <[email protected]>
aprokop
force-pushed
the
update_indexable_getter
branch
from
3c34dfb to
6ffdcf2
Compare
|
Couple irrelevant build failures (out of space, gpu not picked up). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current iteration, if a user has a custom geometry type that they try to build hierarchy on, it has to be tagged with one of the ArborX tags, which would call ArborX routines. This patch relaxes this requirement. Now, a user only needs to specify dimension and coordinate type.
I added a compile-only test that shows the requirements.