arch-nspawn: Generalize mirrorlist sed arch and repo variable replacement #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The host_mirrors value uses a sed pattern that is closely coupled with the mirror URL pattern in-use by most Arch mirrors. For some variants, like Arch Linux ARM, values such as $repo and $arch sit in other parts in the mirror path. This change makes the sed replacement more generic to accomodate for variations in mirrorlist URLs while remaining backward compatible.
bartoszek
reviewed
Mar 10, 2021
|
|
||
| if (( ${#cache_dirs[@]} == 0 )); then | ||
| mapfile -t cache_dirs < <($pacconf_cmd --config "${pac_conf:-$working_dir/etc/pacman.conf}" CacheDir) | ||
| fi | ||
|
|
||
| # shellcheck disable=2016 | ||
| host_mirrors=($($pacconf_cmd --repo extra Server 2> /dev/null | sed -r 's#(.*/)extra/os/.*#\1$repo/os/$arch#')) | ||
| host_mirrors=($($pacconf_cmd --repo extra Server 2> /dev/null | sed -r 's#'"${pacconf_arch}"'#$arch#;s#extra#$repo#')) |
There was a problem hiding this comment.
I see a problem here: what about mirror url containing word extra somewhere beside last path element 😕
|
devtools has been migrated to our GitLab, closing.. Migrated to: https://gitlab.archlinux.org/archlinux/devtools/-/merge_requests/54 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
host_mirrorsvalue uses a sed pattern that is closely coupled with the mirror URL pattern in-use by most Arch mirrors. For some variants, like Arch Linux ARM, values such as$repoand$archsit in other parts in the mirror path. This change makes the sed replacement more generic to accommodate for variations in mirrorlist URLs while remaining backward compatible.I ran into this when trying to use some downstream tools that rely on
arch-nspawn(aurutils) and these changes seem to resolve things for my aarch64 and armv7 hosts.