Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Add makechrootpkg man page #66

Closed

Conversation

yoursweetie
Copy link
Contributor

Add makechrootpkg man page.

@yoursweetie yoursweetie closed this Aug 8, 2021
@anthraxx
Copy link
Member

anthraxx commented Aug 8, 2021

was the close an accident?

@yoursweetie
Copy link
Contributor Author

was the close an accident?

Sorry, I found that more than a file is going to be added.

@anthraxx
Copy link
Member

anthraxx commented Aug 8, 2021

please just force push your feature branch instead of re-creating pull requests 🐱

@yoursweetie
Copy link
Contributor Author

please just force push your feature branch instead of re-creating pull requests

Sorry to disturb, I added other files which should be added & pushed them to my add-doc-makechrootpkg branch. Should I reopen this PR and do something else?

@anthraxx anthraxx reopened this Aug 8, 2021
Copy link
Member

@jelly jelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from some small improvements, it looks good to me!

doc/makechrootpkg.1.asciidoc Outdated Show resolved Hide resolved
doc/makechrootpkg.1.asciidoc Outdated Show resolved Hide resolved
doc/makechrootpkg.1.asciidoc Outdated Show resolved Hide resolved
@jelly
Copy link
Member

jelly commented Sep 7, 2021

Thanks, merged via 80e8c1f

@jelly jelly closed this Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants