makechrootpkg: preserve SSH_AUTH_SOCK to support ssh operations #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sudoforge
changed the title
sudoforge
changed the title
|
Ignore my title changes, looking at URLs to change the copypasta and somehow mucked it up :) |
This commit introduces the preservation of SSH_AUTH_SOCK within the chroot environment, to support SSH-based operations, such as cloning repositories via SSH.
|
Any chance on this getting merged? |
|
Merged via be80928 |
|
Thanks @jelly! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this patch, users who are performing operations over SSH will experience failures. This can cause unexpected results for users who are, for example, building packages using
makechrootpkg, and force all connections to the specified remote(s) ovr SSH, with a stanza similar to below in their Git configuration:Yes, users could be told to update their
sudoconfiguration to preserve the environment variable, however, I find that requiring users to update their configuration in order to work with this tool to be less than desirable.