Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase priority of manually-installed platform. #2810

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Jan 13, 2025

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

Makes the manually-installed platform always preferred over the platforms installed through Board Manager

What is the current behavior?

TODO

What is the new behavior?

TODO

Does this PR introduce a breaking change, and is titled accordingly?

Other information

Draft PR to run the test-suite

@cmaglie cmaglie force-pushed the installed_platform_priority branch from 237d69b to c8b0fc7 Compare January 13, 2025 15:38
@cmaglie cmaglie self-assigned this Jan 13, 2025
@cmaglie cmaglie added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Jan 13, 2025
@cmaglie cmaglie force-pushed the installed_platform_priority branch 2 times, most recently from c3dedb2 to 4de49d3 Compare January 16, 2025 14:04
@cmaglie cmaglie force-pushed the installed_platform_priority branch 3 times, most recently from d248b1e to eb5fe21 Compare February 4, 2025 08:23
@cmaglie cmaglie force-pushed the installed_platform_priority branch from eb5fe21 to 69136e9 Compare February 4, 2025 08:59
@cmaglie cmaglie force-pushed the installed_platform_priority branch from 69136e9 to dad5063 Compare February 4, 2025 09:58
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 89.11565% with 16 lines in your changes missing coverage. Please review.

Project coverage is 67.80%. Comparing base (5f84ecb) to head (dad5063).

Files with missing lines Patch % Lines
internal/arduino/cores/packagemanager/loader.go 86.07% 5 Missing and 6 partials ⚠️
internal/cli/core/list.go 50.00% 2 Missing and 1 partial ⚠️
.../arduino/cores/packagemanager/install_uninstall.go 50.00% 0 Missing and 1 partial ⚠️
...al/arduino/cores/packagemanager/package_manager.go 95.65% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2810      +/-   ##
==========================================
+ Coverage   67.74%   67.80%   +0.06%     
==========================================
  Files         238      238              
  Lines       22410    22416       +6     
==========================================
+ Hits        15181    15200      +19     
+ Misses       6034     6024      -10     
+ Partials     1195     1192       -3     
Flag Coverage Δ
unit 67.80% <89.11%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant