fix(deps) Update starknet-reacts next to 3.0.0-beta.3 #37
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Decouple components using different lib versions.
Decouple components using different lib versions.
|
|
||
| const buttonsDisabled = ["approve", "pending"].includes(transactionStatus) | ||
|
|
||
| const { contract } = useContract({ |
There was a problem hiding this comment.
using new api from newest version of starknet-react
| "starknet-react-chains-next": "npm:@starknet-react/[email protected].3", | ||
| "starknet-react-core-next": "npm:@starknet-react/[email protected].3", |
There was a problem hiding this comment.
Not sure if we should set it to this version or will they release the final one?
There was a problem hiding this comment.
I guess there shouldn't be any differences, just curious
There was a problem hiding this comment.
idk to be honest, but it is a good question
|
|
||
| export const MintWithStarknetReact = () => { | ||
| const { account } = useAccount() | ||
| const [mintAmount, setMintAmount] = useState("10") |
There was a problem hiding this comment.
Should this be prepopulated with 10?
There was a problem hiding this comment.
It's a copy-paste from previous component, so didn't want to change it. I assume it's just some random default
| value={mintAmount} | ||
| onChange={(e) => setMintAmount(e.target.value)} | ||
| /> | ||
| {/* TODO: When will we allow below? Need to ask Ale */} |
There was a problem hiding this comment.
Not sure why would we disable it at all, after all it's just an example dapp?
There was a problem hiding this comment.
I asked Ale and blockchian team. He basically said it's always been there. Going yolo and enabling the submit 😂
| <Input | ||
| type="submit" | ||
| disabled={true || buttonsDisabled} | ||
| value="Not possible with ETH!" |
There was a problem hiding this comment.
value="Not possible with ETH!" what does this mean?
There was a problem hiding this comment.
I asked Ale and blockchian team. He basically said it's always been there. Going yolo and enabling the submit 😂
| export const TransferWithStarknetReact = () => { | ||
| const { account } = useAccount() | ||
| const [transferTo, setTransferTo] = useState("") | ||
| const [transferAmount, setTransferAmount] = useState("1") |
No description provided.