gpio: gpio_intel_apl: fix if condition leading to dead code

GPIO_INT_ACTIVE_LOW is 0 which means it cannot be simply AND-ed. So fix the condition. Fixes zephyrproject-rtos#13880 Signed-off-by: Daniel Leung <[email protected]>
argentum-systems · Feb 28, 2019 · 1af5fa1 · 1af5fa1
1 parent ca3b6c6
commit 1af5fa1
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/drivers/gpio/gpio_intel_apl.c b/drivers/gpio/gpio_intel_apl.c
@@ -243,7 +243,7 @@ static int gpio_intel_apl_config(struct device *dev, int access_op,
 	/* setup interrupt if desired */
 	if (flags & GPIO_INT) {
 		/* invert signal for interrupt controller */
-		if (flags & GPIO_INT_ACTIVE_LOW) {
+		if ((flags & GPIO_INT_ACTIVE_HIGH) == GPIO_INT_ACTIVE_LOW) {
 			cfg0 |= PAD_CFG0_RXINV;
 		}