-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support loading parameter values from secrets. Fixes: #5506 #13899
base: main
Are you sure you want to change the base?
Conversation
c9383cb
to
5d65f3c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you paste some example outputs and screenshots?
Signed-off-by: shuangkun <[email protected]>
Signed-off-by: shuangkun <[email protected]>
Signed-off-by: shuangkun <[email protected]>
Signed-off-by: shuangkun <[email protected]>
Co-authored-by: shuangkun <[email protected]> Co-authored-by: Jinsu Park <[email protected]> Signed-off-by: shuangkun <[email protected]>
Signed-off-by: shuangkun <[email protected]>
Signed-off-by: shuangkun <[email protected]>
Signed-off-by: shuangkun <[email protected]>
Signed-off-by: shuangkun <[email protected]>
Signed-off-by: shuangkun <[email protected]>
2496146
to
95d1338
Compare
Signed-off-by: shuangkun <[email protected]>
Signed-off-by: shuangkun <[email protected]>
Sure.
|
@@ -17,4 +17,5 @@ rules: | |||
- secrets | |||
verbs: | |||
- get | |||
- watch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This introduces a new requirement. @jessesuen Would you be okay with this addition?
Fixes #5506 Reference: #11446
Unsolved issues:
Hide secret value in argo template, log, UI
Motivation
Modifications
Verification
Loccal Test and UT