-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor(module_utils): Create resource submodules for fields and schemas #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Conflicts have been resolved. A maintainer will review the pull request shortly. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Conflicts have been resolved. A maintainer will review the pull request shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
module: cv_configlet_v3
Issue related to cv_cononfiglet module in v3
module: cv_container_v3
Issue related to cv_container module in v3
module: cv_device_v3
Issue related to cv_device module in v3
module: cv_facts_v3
module_utils: cv_client
cv_client implementation issue
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Instead of using definition of FIELDS in each tool, this PR use a global field definition that helps code to be more consistant and helps for maintenance.
Related Issue(s)
N/A
Component(s) name
module_utils
Proposed changes
Create a resources module with following elements:
resources.api.fields
:Api
: List all fields used in modules with following classification:generic
: All fields used regardless of resource typedevice
: All fields specific to device resource managementcontainer
: All fields specific to container resource managementconfiglet
: All fields specific to configlet resource managementtask
: All fields specific to task resource managementresources.modules.fields
ModuleOptionValues
to get some values related to ansible input like mode or stateresources.schemas
How to test
Run all existing worklfows and check if there is unexpected changes
Checklist
User Checklist
cv_facts_v3
Repository Checklist