Feat(eos_designs): Add support for l3_port_channel_interfaces for WAN #4752

ashenoy-arista · 2024-11-21T17:10:02Z

Change Summary

Revised schema to support L3 Port-Channel interfaces and supporting changes to eos_designs
Primary use-case is to allow such interfaces as wan-facing interfaces.

Related Issue(s)

Fixes #4695

Component(s) name

arista.avd.eos_designs

Proposed changes

How to test

This change introduces revised schema within eos_designs with node key l3_port_channels
to represent L3 port-channel interfaces that may be used as wan-facing interfaces.
Includes logic to support the newly added schema and unit tests to validate handling of newly added schema attributes.
Internet exit policy is not yet supported for L3 Port-Channel interface.
Interface tags are being generated for L3 Port-Channel interfaces.

Checklist

User Checklist

N/A

Repository Checklist

My code has been rebased from devel before I start
I have read the CONTRIBUTING document.
My change requires a change to the documentation and documentation have been updated accordingly.
I have updated molecule CI testing accordingly. (check the box if not applicable)

github-actions · 2024-11-21T17:10:32Z

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4752
# Activate the virtual environment
source test-avd-pr-4752/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/ashenoy-arista/avd.git@samplePRBranch#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/ashenoy-arista/avd.git#/ansible_collections/arista/avd/,samplePRBranch --force
# Optional: Install AVD examples
cd test-avd-pr-4752
ansible-playbook arista.avd.install_examples

...on-avd/pyavd/_eos_designs/schema/schema_fragments/defs_node_type_l3_port_channels.schema.yml

python-avd/pyavd/_eos_designs/schema/schema_fragments/defs_node_type.schema.yml

python-avd/pyavd/api/interface_descriptions/__init__.py

...rista/avd/molecule/eos_designs_unit_tests/inventory/host_vars/node-type-l3-port-channels.yml

python-avd/pyavd/_eos_designs/shared_utils/l3_port_channels.py

python-avd/pyavd/_eos_designs/shared_utils/wan.py

python-avd/pyavd/_eos_designs/structured_config/base/__init__.py

python-avd/pyavd/_eos_designs/structured_config/network_services/utils_wan.py

python-avd/pyavd/_eos_designs/structured_config/underlay/static_routes.py

python-avd/pyavd/api/interface_descriptions/__init__.py

github-actions · 2025-01-22T01:46:49Z

Conflicts have been resolved. A maintainer will review the pull request shortly.

gmuloc · 2025-01-23T15:47:06Z

On the call:

remove internet_exit from schema to block it for now
WAN how-to page document - no IE policy on port-channel
Port-channel tags to be added in metadata

python-avd/pyavd/_eos_designs/structured_config/underlay/utils.py

python-avd/pyavd/_eos_designs/structured_config/network_services/utils_wan.py

python-avd/pyavd/_eos_designs/structured_config/underlay/port_channel_interfaces.py

github-actions · 2025-01-30T08:06:31Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

…es/utils_wan.py Co-authored-by: Guillaume Mulocher <[email protected]>

github-actions · 2025-01-30T13:33:18Z

Conflicts have been resolved. A maintainer will review the pull request shortly.

gmuloc

We also need to update the WAN how-to to indicate this feature

gmuloc · 2025-01-30T13:57:19Z

python-avd/pyavd/_eos_designs/structured_config/metadata/cv_tags.py

+        for port_channel_intf in self.structured_config.port_channel_interfaces:
+            tags = []
+            if self.shared_utils.is_cv_pathfinder_router:
+                tags.extend(self._get_cv_pathfinder_interface_tags(port_channel_intf))
+            if tags:
+                interface_tags.append({"interface": port_channel_intf.name, "tags": tags})


feels like this coul be simplified because we are not parsing tags_to_generate for l3 port-channels. @ClausHolbechArista should we?

python-avd/pyavd/_eos_designs/shared_utils/wan.py

...tive_unit_tests/inventory/host_vars/l3-port-channel-sub-interface-with-member-interfaces.yml

..._designs_negative_unit_tests/inventory/host_vars/l3-port-channel-sub-interface-with-mode.yml

gmuloc · 2025-01-30T20:26:05Z

ansible_collections/arista/avd/examples/cv-pathfinder/group_vars/SITE3.yml

-      l3_interfaces:
-        - name: Ethernet4
-          peer_interface: Ethernet8
+      l3_port_channels:


we need to change the diagrams

@ClausHolbechArista lets see if it does not make sense to add another member interface in the picture for the example (we would need to adjust EVE-NG but we can survive)

gmuloc · 2025-01-30T20:35:23Z

...s/arista/avd/molecule/eos_designs_unit_tests/intended/configs/node-type-l3-port-channels.cfg

+   ip address 192.168.142.1/32
+!
+interface Ethernet1
+   description peerDevice1_Ethernet11


open question:

for members for WAN L3 Port channels, would it make sense to repear wan_carrier on the member description

@ClausHolbechArista

python-avd/pyavd/_eos_designs/shared_utils/wan.py

for more information, see https://pre-commit.ci

sonarqubecloud · 2025-01-30T21:31:53Z

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

ashenoy-arista requested review from a team as code owners November 21, 2024 17:10

github-actions bot added state: Documentation role Updated role: eos_designs issue related to eos_designs role labels Nov 21, 2024

github-actions bot assigned ashenoy-arista Nov 21, 2024

ashenoy-arista marked this pull request as draft November 21, 2024 17:10

github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role type: code quality CI and development toolset state: CI Updated CI scenario have been updated in the PR labels Nov 21, 2024

ashenoy-arista force-pushed the samplePRBranch branch from 2f1a500 to d3086d9 Compare November 21, 2024 20:06

github-actions bot removed role: eos_cli_config_gen issue related to eos_cli_config_gen role type: code quality CI and development toolset state: CI Updated CI scenario have been updated in the PR labels Nov 21, 2024

ashenoy-arista force-pushed the samplePRBranch branch from d3086d9 to 7d8c276 Compare November 21, 2024 21:11

ClausHolbechArista reviewed Nov 23, 2024

View reviewed changes

ashenoy-arista force-pushed the samplePRBranch branch 2 times, most recently from a8fa6b9 to 1d61e17 Compare November 27, 2024 20:49

ashenoy-arista force-pushed the samplePRBranch branch from 2e10ead to f35199a Compare December 3, 2024 01:47

github-actions bot added the state: CI Updated CI scenario have been updated in the PR label Dec 3, 2024

ashenoy-arista force-pushed the samplePRBranch branch 2 times, most recently from cfae876 to fccd4c8 Compare December 3, 2024 04:05

XiangyiGuo reviewed Dec 3, 2024

View reviewed changes

python-avd/pyavd/api/interface_descriptions/__init__.py Show resolved Hide resolved

ashenoy-arista force-pushed the samplePRBranch branch 2 times, most recently from b8175d8 to ffc3188 Compare December 5, 2024 06:50

ClausHolbechArista changed the title ~~Feat(eos_designs): Add revised schema to support L3 Port-Channel interfaces~~ Feat(eos_designs): Add suport for l3_port_channel_interfaces for WAN Dec 6, 2024

ClausHolbechArista requested changes Dec 6, 2024

View reviewed changes

ashenoy-arista force-pushed the samplePRBranch branch 3 times, most recently from c689203 to 41612ab Compare December 12, 2024 07:39

ashenoy-arista force-pushed the samplePRBranch branch 4 times, most recently from fd72134 to 67fe5e5 Compare January 23, 2025 01:04

ashenoy-arista force-pushed the samplePRBranch branch 2 times, most recently from 7be99ea to a38bdbe Compare January 24, 2025 00:29

ClausHolbechArista added this to the v5.2.0 milestone Jan 27, 2025

ClausHolbechArista requested changes Jan 29, 2025

View reviewed changes

ashenoy-arista force-pushed the samplePRBranch branch from 207490d to 0f06391 Compare January 29, 2025 19:38

Feat(eos_designs): Add support for l3_port_channel_interfaces for WAN

be87c96

ashenoy-arista force-pushed the samplePRBranch branch from 0f06391 to be87c96 Compare January 29, 2025 23:31

github-actions bot added the state: conflict PR with conflict label Jan 30, 2025

ClausHolbechArista and others added 3 commits January 30, 2025 13:30

Update python-avd/pyavd/_eos_designs/structured_config/network_servic…

84d60d9

…es/utils_wan.py Co-authored-by: Guillaume Mulocher <[email protected]>

Merge branch 'devel' into samplePRBranch

df8a8a5

Test: Cleaning extra data not useful for the test

2eec7ba

github-actions bot removed the state: conflict PR with conflict label Jan 30, 2025

gmuloc requested changes Jan 30, 2025

View reviewed changes

gmuloc and others added 8 commits January 30, 2025 22:01

Apply suggestions from code review

24945e9

Refactor: Fix type hints

58eed7a

Test: Moleculing the molecule

25abe5d

[pre-commit.ci] auto fixes from pre-commit.com hooks

f8263e6

for more information, see https://pre-commit.ci

Doc: Update WAN how-to

7db8893

Refactor: Adjust shared_utils wan.py

7cd149b

Test: Simplify test input

0131f2f

Refactor: Fix docstring

68216a3

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat(eos_designs): Add support for l3_port_channel_interfaces for WAN #4752

Feat(eos_designs): Add support for l3_port_channel_interfaces for WAN #4752

ashenoy-arista commented Nov 21, 2024 •

edited

Loading

github-actions bot commented Nov 21, 2024

github-actions bot commented Jan 22, 2025

gmuloc commented Jan 23, 2025 •

edited

Loading

github-actions bot commented Jan 30, 2025

github-actions bot commented Jan 30, 2025

gmuloc left a comment

gmuloc Jan 30, 2025

gmuloc Jan 30, 2025

gmuloc Jan 30, 2025

gmuloc Jan 30, 2025

sonarqubecloud bot commented Jan 30, 2025

Feat(eos_designs): Add support for l3_port_channel_interfaces for WAN #4752

Are you sure you want to change the base?

Feat(eos_designs): Add support for l3_port_channel_interfaces for WAN #4752

Conversation

ashenoy-arista commented Nov 21, 2024 • edited Loading

Change Summary

Related Issue(s)

Component(s) name

Proposed changes

How to test

Checklist

User Checklist

Repository Checklist

github-actions bot commented Nov 21, 2024

github-actions bot commented Jan 22, 2025

gmuloc commented Jan 23, 2025 • edited Loading

github-actions bot commented Jan 30, 2025

github-actions bot commented Jan 30, 2025

gmuloc left a comment

Choose a reason for hiding this comment

gmuloc Jan 30, 2025

Choose a reason for hiding this comment

gmuloc Jan 30, 2025

Choose a reason for hiding this comment

gmuloc Jan 30, 2025

Choose a reason for hiding this comment

gmuloc Jan 30, 2025

Choose a reason for hiding this comment

sonarqubecloud bot commented Jan 30, 2025

Quality Gate passed

ashenoy-arista commented Nov 21, 2024 •

edited

Loading

gmuloc commented Jan 23, 2025 •

edited

Loading