Refactor(eos_designs): Remove dependency on overlay_routing_protocol and evpn_role for WAN routers

[gmuloc]

Change Summary

This is a stepping stone PR to introduce EVPN GW between DPS and VXLAN in PR #4831

Since the intro of the WAN routers, the overlay_routing_protocol HAD to be ibgp and the evpn_role HAD to be the same as the wan_role. Making both keys being essentially ignored.
This PR decorelates and "relax" the requirements.

It introduces a new boolean that continue to ignore the keys and it is enabled by default in order to prevent extra configuration to be generated. the knob is added as PREVIEW

Component(s) name

arista.avd.eos_designs

Proposed changes

• [Adjust multiple places where the code was implicitly relying on iBGP / evpn_role == wan_role for decisions around iBGP and so on. Relying only on wan_router + wan_role (eventually could add later relying on wan_mode but today both are actually using iBGP)
• Adjust schema to remove the limitations
• Remove negative unit tests

How to test

• molecule test should render the same.
• need to add new molecule test to enable EVPN on LAN and be happy

Checklist

User Checklit

• need to review WAN how-to to clean it up
• need to review cv-pathfinder example to clean it up

Repository Checklist

• My code has been rebased from devel before I start
• I have read the CONTRIBUTING document.
• My change requires a change to the documentation and documentation have been updated accordingly.
• I have updated molecule CI testing accordingly. (check the box if not applicable)

[github-actions]

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4865
# Activate the virtual environment
source test-avd-pr-4865/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/gmuloc/avd.git@relax-wan-default-requirements#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/gmuloc/avd.git#/ansible_collections/arista/avd/,relax-wan-default-requirements --force
# Optional: Install AVD examples
cd test-avd-pr-4865
ansible-playbook arista.avd.install_examples

[gmuloc]

@ClausHolbechArista right now this is stil generated and I am not sure we want that.

[ClausHolbechArista]

no we don't

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions]

Conflicts have been resolved. A maintainer will review the pull request shortly.

[sonarqubecloud]

Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud