Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extbldr: added mock subcommand with basic options #18

Merged
merged 1 commit into from
Sep 13, 2022
Merged

Conversation

shyammohan-arista
Copy link
Contributor

added mock subcommand to build RPM from SRPMs. This internally calls the
mock tool to build the RPM in the architecture specified.
works with default config as of now. quiet option added for mock

Copy link
Collaborator

@aajith-arista aajith-arista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't do a full pass.
Some initial comments

@shyammohan-arista shyammohan-arista force-pushed the mock-1 branch 6 times, most recently from b004adf to 04c3daf Compare September 2, 2022 05:34
@shyammohan-arista shyammohan-arista marked this pull request as ready for review September 2, 2022 05:49
@shyammohan-arista shyammohan-arista force-pushed the mock-1 branch 4 times, most recently from e415af0 to 12f6366 Compare September 2, 2022 06:26
@shyammohan-arista shyammohan-arista force-pushed the mock-1 branch 4 times, most recently from 53414b7 to efcf64a Compare September 6, 2022 09:08
@shyammohan-arista shyammohan-arista force-pushed the mock-1 branch 11 times, most recently from ba3572a to 72d4fcd Compare September 7, 2022 07:50
Copy link
Collaborator

@aajith-arista aajith-arista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't looked at the test changes yet.
Will look at it after my meetings.

@shyammohan-arista shyammohan-arista force-pushed the mock-1 branch 9 times, most recently from 445600f to ad275eb Compare September 12, 2022 10:12
Copy link
Collaborator

@aajith-arista aajith-arista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM mostly.

I don't see you use SetupManifest ?
Maybe you can just get rid of the testutil stuff now ?

@shyammohan-arista
Copy link
Contributor Author

LGTM mostly.

I don't see you use SetupManifest ? Maybe you can just get rid of the testutil stuff now ?

Will need the manifest in next step.
Test case For generating config file.
Figured I can re use thus then. Hence left as is for now

added mock subcommand to build RPM from SRPMs. This internally calls the
mock tool to build the RPM in the architecture specified.
works with default config as of now. quiet option added for mock.
Added a testUtil file to collate common test functions under util
package.
Copy link
Collaborator

@aajith-arista aajith-arista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shyammohan-arista shyammohan-arista merged commit 3bdbf20 into main Sep 13, 2022
@shyammohan-arista shyammohan-arista deleted the mock-1 branch September 13, 2022 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants