-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extbldr: added mock subcommand with basic options #18
Conversation
ad53c68
to
1f3a81b
Compare
1f3a81b
to
53adb0d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't do a full pass.
Some initial comments
b004adf
to
04c3daf
Compare
e415af0
to
12f6366
Compare
12f6366
to
93b1d32
Compare
53414b7
to
efcf64a
Compare
ba3572a
to
72d4fcd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't looked at the test changes yet.
Will look at it after my meetings.
445600f
to
ad275eb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM mostly.
I don't see you use SetupManifest ?
Maybe you can just get rid of the testutil stuff now ?
Will need the manifest in next step. |
added mock subcommand to build RPM from SRPMs. This internally calls the mock tool to build the RPM in the architecture specified. works with default config as of now. quiet option added for mock. Added a testUtil file to collate common test functions under util package.
ad275eb
to
3bdbf20
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
added mock subcommand to build RPM from SRPMs. This internally calls the
mock tool to build the RPM in the architecture specified.
works with default config as of now. quiet option added for mock