Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: avoid duplicate crates #942

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

rex4539
Copy link
Contributor

@rex4539 rex4539 commented Feb 24, 2025

No description provided.

@rex4539 rex4539 requested review from a team as code owners February 24, 2025 22:20
@rex4539 rex4539 requested review from z-tech, mmagician and weikengchen and removed request for a team February 24, 2025 22:20
@z-tech
Copy link
Contributor

z-tech commented Feb 26, 2025

Hi, thank you for this contribution. Can you please provide motivation for the changes submitted?

Maybe helpful:

  • If changes modify existing behavior, why are the changes both safe (backwards compatible) and needed
  • If changes add new features, please explain what the new features do and how they will be used

For more info please refer to the contribution guidelines and the PR template provided.

Thanks.

@z-tech
Copy link
Contributor

z-tech commented Feb 26, 2025

Clippy suggestions

@rex4539
Copy link
Contributor Author

rex4539 commented Feb 26, 2025

When you have multiple packages in a Cargo workspace, you often end up depending on the same packages in multiple Cargo.toml files.

This duplication can become an issue:

When you want to update a dependency, you have to update it in multiple places.
When you need to add a new dependency, you first have to check if it's already used in another package of your workspace to keep versions in sync.

This process is error-prone and tedious.

If you mess it up, you end up with different versions of the same dependency within your workspace. This can lead to hard-to-debug compilation errors or bloat your artifacts with unnecessary copies of the same package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants