Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch inner product proofs to Merlin for Fiat-Shamir transform #39

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Switch inner product proofs to Merlin for Fiat-Shamir transform #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ce099ec
Transitioned GIPA to merlin
rozbb Aug 22, 2021
6e1ac9b
Transitioned rest of ip_proofs to merlin
rozbb Aug 22, 2021
d108cb9
Small tweaks to GIPA
rozbb Aug 22, 2021
da71376
Transitioned SIPP to merlin
rozbb Aug 22, 2021
5197693
Generalized GIPA transcript helper function a bit
rozbb Aug 22, 2021
eb54bee
Transitioned all applications to merlin too
rozbb Aug 22, 2021
bfc3993
Transitioned all benches to merlin
rozbb Aug 22, 2021
001c359
Forgot about poly_commit bench
rozbb Aug 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions benches/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,7 @@ ark-bw6-761 = "0.3"
ark-relations = "0.3"
ark-r1cs-std = "0.3"

digest = "0.9"
blake2 = "0.9"
merlin = "3"
csv = "1"

ark-inner-products = { path = "../inner_products" }
Expand Down
25 changes: 15 additions & 10 deletions benches/benches/gipa.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,12 @@ use ark_inner_products::{
use ark_ip_proofs::gipa::GIPA;

use ark_std::rand::{rngs::StdRng, Rng, SeedableRng};
use blake2::Blake2b;
use digest::Digest;

use merlin::Transcript;
use std::{ops::MulAssign, time::Instant};

fn bench_gipa<IP, LMC, RMC, IPC, D, R: Rng>(rng: &mut R, len: usize)
fn bench_gipa<IP, LMC, RMC, IPC, R: Rng>(rng: &mut R, len: usize)
where
D: Digest,
IP: InnerProduct<
LeftMessage = LMC::Message,
RightMessage = RMC::Message,
Expand All @@ -45,23 +43,32 @@ where
r.push(<IP::RightMessage>::rand(rng));
}

let (ck_l, ck_r, ck_t) = GIPA::<IP, LMC, RMC, IPC, D>::setup(rng, len).unwrap();
let (ck_l, ck_r, ck_t) = GIPA::<IP, LMC, RMC, IPC>::setup(rng, len).unwrap();
let com_l = LMC::commit(&ck_l, &l).unwrap();
let com_r = RMC::commit(&ck_r, &r).unwrap();
let t = vec![IP::inner_product(&l, &r).unwrap()];
let com_t = IPC::commit(&vec![ck_t.clone()], &t).unwrap();
let mut proof_transcript = Transcript::new(b"GIPA-bench");
let mut start = Instant::now();
let proof = GIPA::<IP, LMC, RMC, IPC, D>::prove(
let proof = GIPA::<IP, LMC, RMC, IPC>::prove(
&mut proof_transcript,
(&l, &r, &t[0]),
(&ck_l, &ck_r, &ck_t),
(&com_l, &com_r, &com_t),
)
.unwrap();
let mut bench = start.elapsed().as_millis();
println!("\t proving time: {} ms", bench);

let mut verif_transcript = Transcript::new(b"GIPA-bench");
start = Instant::now();
GIPA::<IP, LMC, RMC, IPC, D>::verify((&ck_l, &ck_r, &ck_t), (&com_l, &com_r, &com_t), &proof)
.unwrap();
GIPA::<IP, LMC, RMC, IPC>::verify(
&mut verif_transcript,
(&ck_l, &ck_r, &ck_t),
(&com_l, &com_r, &com_t),
&proof,
)
.unwrap();
bench = start.elapsed().as_millis();
println!("\t verification time: {} ms", bench);
}
Expand All @@ -81,7 +88,6 @@ fn main() {
GC1,
GC2,
IdentityCommitment<ExtensionFieldElement<Bls12_381>, <Bls12_381 as PairingEngine>::Fr>,
Blake2b,
StdRng,
>(&mut rng, LEN);

Expand All @@ -94,7 +100,6 @@ fn main() {
<Bls12_381 as PairingEngine>::G1Projective,
<Bls12_381 as PairingEngine>::Fr,
>,
Blake2b,
StdRng,
>(&mut rng, LEN);
}
14 changes: 8 additions & 6 deletions benches/benches/groth16_aggregation/bench.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,8 @@ use ark_ip_proofs::applications::groth16_aggregation::{
aggregate_proofs, setup_inner_product, verify_aggregate_proof,
};

use ark_std::rand::{rngs::StdRng, SeedableRng};
use blake2::Blake2b;
use csv::Writer;
use merlin::Transcript;

use std::{io::stdout, time::Instant};

Expand Down Expand Up @@ -248,7 +247,7 @@ fn main() {
csv_writer.flush().unwrap();
let mut start;
let mut time;
let mut rng = StdRng::seed_from_u64(0u64);
let mut rng = ark_std::test_rng();

// Compute hashes
let mut hash_inputs = vec![];
Expand Down Expand Up @@ -344,7 +343,7 @@ fn main() {
// Benchmark aggregation via IPA
{
start = Instant::now();
let srs = setup_inner_product::<Bls12_377, Blake2b, _>(&mut rng, num_proofs).unwrap();
let srs = setup_inner_product::<Bls12_377, _>(&mut rng, num_proofs).unwrap();
time = start.elapsed().as_millis();
csv_writer
.write_record(&[
Expand All @@ -359,9 +358,10 @@ fn main() {
let v_srs = srs.get_verifier_key();

for i in 1..=num_trials {
let mut proof_transcript = Transcript::new(b"Groth16-agg-bench");
start = Instant::now();
let aggregate_proof =
aggregate_proofs::<Bls12_377, Blake2b>(&srs, &proofs).unwrap();
aggregate_proofs::<Bls12_377>(&mut proof_transcript, &srs, &proofs).unwrap();
time = start.elapsed().as_millis();
csv_writer
.write_record(&[
Expand All @@ -374,8 +374,10 @@ fn main() {
.unwrap();
csv_writer.flush().unwrap();

let mut verif_transcript = Transcript::new(b"Groth16-agg-bench");
start = Instant::now();
let result = verify_aggregate_proof(
&mut verif_transcript,
&v_srs,
&hash_circuit_parameters.0.vk,
&hash_outputs
Expand Down Expand Up @@ -533,7 +535,7 @@ pub fn batch_verify_proof<E: PairingEngine>(
public_inputs: &[Vec<E::Fr>],
proofs: &[Proof<E>],
) -> Result<bool, SynthesisError> {
let mut rng = StdRng::seed_from_u64(0u64);
let mut rng = ark_std::test_rng();
let mut r_powers = Vec::with_capacity(proofs.len());
for _ in 0..proofs.len() {
let challenge: E::Fr = u128::rand(&mut rng).into();
Expand Down
5 changes: 3 additions & 2 deletions benches/benches/inner_products.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ use ark_ec::PairingEngine;
use ark_ff::UniformRand;
use ark_inner_products::{InnerProduct, MultiexponentiationInnerProduct, PairingInnerProduct};

use ark_std::rand::{rngs::StdRng, Rng, SeedableRng};
use ark_std::rand::{rngs::StdRng, Rng};

use std::time::Instant;

Expand All @@ -26,7 +26,8 @@ where

fn main() {
const LEN: usize = 16;
let mut rng = StdRng::seed_from_u64(0u64);
let mut rng = ark_std::test_rng();

println!("Benchmarking inner products with vector length: {}", LEN);

println!("1) Pairing inner product...");
Expand Down
50 changes: 36 additions & 14 deletions benches/benches/poly_commit.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ use ark_poly::polynomial::{

use ark_std::rand::{rngs::StdRng, SeedableRng};
use csv::Writer;
use merlin::Transcript;

use blake2::Blake2b;
use std::{
io::stdout,
time::{Duration, Instant},
Expand Down Expand Up @@ -51,7 +51,8 @@ fn main() {
for degree in (0..num_data_points).map(|i| 4_usize.pow((i + 1) as u32) - 1) {
// Benchmark KZG
{
let mut rng = StdRng::seed_from_u64(0u64);
let mut rng = ark_std::test_rng();

start = Instant::now();
let (g_alpha_powers, v_srs) = KZG::<Bls12_381>::setup(&mut rng, degree).unwrap();
time = start.elapsed().as_millis();
Expand Down Expand Up @@ -124,7 +125,7 @@ fn main() {
{
let mut rng = StdRng::seed_from_u64(0u64);
start = Instant::now();
let srs = IPA::<Bls12_381, Blake2b>::setup(&mut rng, degree).unwrap();
let srs = IPA::<Bls12_381>::setup(&mut rng, degree).unwrap();
let v_srs = srs.0.get_verifier_key();
time = start.elapsed().as_millis();
csv_writer
Expand All @@ -144,8 +145,7 @@ fn main() {

// Commit
start = Instant::now();
let (com, prover_aux) =
IPA::<Bls12_381, Blake2b>::commit(&srs, &polynomial).unwrap();
let (com, prover_aux) = IPA::<Bls12_381>::commit(&srs, &polynomial).unwrap();
time = start.elapsed().as_millis();
csv_writer
.write_record(&[
Expand All @@ -158,9 +158,16 @@ fn main() {
.unwrap();

// Open
let mut proof_transcript = Transcript::new(b"IPA-bench");
start = Instant::now();
let proof = IPA::<Bls12_381, Blake2b>::open(&srs, &polynomial, &prover_aux, &point)
.unwrap();
let proof = IPA::<Bls12_381>::open(
&mut proof_transcript,
&srs,
&polynomial,
&prover_aux,
&point,
)
.unwrap();
time = start.elapsed().as_millis();
csv_writer
.write_record(&[
Expand All @@ -174,10 +181,17 @@ fn main() {

// Verify
std::thread::sleep(Duration::from_millis(5000));
let verif_transcript = Transcript::new(b"IPA-bench");
start = Instant::now();
for _ in 0..50 {
let is_valid = IPA::<Bls12_381, Blake2b>::verify(
&v_srs, degree, &com, &point, &eval, &proof,
let is_valid = IPA::<Bls12_381>::verify(
&mut verif_transcript.clone(),
&v_srs,
degree,
&com,
&point,
&eval,
&proof,
)
.unwrap();
assert!(is_valid);
Expand All @@ -199,7 +213,7 @@ fn main() {
{
let mut rng = StdRng::seed_from_u64(0u64);
start = Instant::now();
let ck = TransparentIPA::<Bls12_381, Blake2b>::setup(&mut rng, degree).unwrap();
let ck = TransparentIPA::<Bls12_381>::setup(&mut rng, degree).unwrap();
time = start.elapsed().as_millis();
csv_writer
.write_record(&[
Expand All @@ -219,7 +233,7 @@ fn main() {
// Commit
start = Instant::now();
let (com, prover_aux) =
TransparentIPA::<Bls12_381, Blake2b>::commit(&ck, &polynomial).unwrap();
TransparentIPA::<Bls12_381>::commit(&ck, &polynomial).unwrap();
time = start.elapsed().as_millis();
csv_writer
.write_record(&[
Expand All @@ -232,8 +246,10 @@ fn main() {
.unwrap();

// Open
let mut proof_transcript = Transcript::new(b"IPA_transparent-bench");
start = Instant::now();
let proof = TransparentIPA::<Bls12_381, Blake2b>::open(
let proof = TransparentIPA::<Bls12_381>::open(
&mut proof_transcript,
&ck,
&polynomial,
&prover_aux,
Expand All @@ -252,11 +268,17 @@ fn main() {
.unwrap();

// Verify
let verif_transcript = Transcript::new(b"IPA_transparent-bench");
std::thread::sleep(Duration::from_millis(5000));
start = Instant::now();
for _ in 0..50 {
let is_valid = TransparentIPA::<Bls12_381, Blake2b>::verify(
&ck, &com, &point, &eval, &proof,
let is_valid = TransparentIPA::<Bls12_381>::verify(
&mut verif_transcript.clone(),
&ck,
&com,
&point,
&eval,
&proof,
)
.unwrap();
assert!(is_valid);
Expand Down
Loading