Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow output_format to be defined from ini setting #97

Merged
merged 3 commits into from
Nov 29, 2023
Merged

Allow output_format to be defined from ini setting #97

merged 3 commits into from
Nov 29, 2023

Conversation

gaelreyrol
Copy link
Contributor

@gaelreyrol gaelreyrol commented Nov 28, 2023 •
edited
Loading

Hi @arnaud-lb,

I have not written C since a long time, I expect my code to not be as clean as it should.

I have one concern, I think the output_format should be validated before calling memprof_zend_error_cb_dump.

Looking forward your feedback 🙂

arnaud-lb
arnaud-lb reviewed Nov 28, 2023
View reviewed changes
Copy link
Owner

@arnaud-lb arnaud-lb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

memprof.c Outdated Show resolved Hide resolved
php_memprof.h Outdated Show resolved Hide resolved
@gaelreyrol gaelreyrol requested a review from arnaud-lb November 29, 2023 07:59
@arnaud-lb arnaud-lb merged commit 89a5736 into arnaud-lb:v3 Nov 29, 2023
6 checks passed
@arnaud-lb
Copy link
Owner

Thank you!

@gaelreyrol gaelreyrol deleted the php-ini-output-format branch November 29, 2023 12:35
@arnaud-lb arnaud-lb mentioned this pull request Apr 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnaud-lb arnaud-lb Awaiting requested review from arnaud-lb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gaelreyrol @arnaud-lb