Delimiter editing fixes #1932
Merged
Delimiter editing fixes #1932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add regression tests for arnog#1691, arnog#1375, and arnog#1845 Add failing test for arnog#1656 and arnog#1742 and for issue where deleting and re-adding left delimiter doesn't trigger input event.
Also fixes issue where, when left delimiter was deleted and replaced, a input event was not triggered.
Fixes issues when deleting left delimiter and replacing it inside and outside the leftright atom. Based off of implementation for same situation on right delimiter since that case worked well. Added tests for both the fixed left delimiter cases and the already working right delimiter cases.
|
I added some additional fixes that handle cases where the left delimiter is deleted and replace either inside or outside of the LeftRight atom. I based it on how this is currently handled for the right delimiter case. I've added tests for both the left delimiter and right delimiter cases. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1656 and #1742 (#1742 is a duplicate of #1656). This pull request also fixes a regression of #1691 (the #1691 regression occurred since 0.91.2, I didn't determine exactly which commit introduced the regression).
Additionally, fixes issue where deleting left delimiter and retyping left delimiter did not trigger an input event.
End-to-end tests have been added for these fixes and the previous delimiter issues (#1691, #1375, and #1845) to make sure regressions were not introduced with these changes and to make sure any regressions on these issues will be detected in the future.