Fix LACP warnings modules found by sanity tools #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ERROR: plugins/modules/arubaoss_lacp.py:101:112: E261: at least two spaces before inline comment ERROR: plugins/modules/arubaoss_lacp.py:103:47: E261: at least two spaces before inline comment ERROR: plugins/modules/arubaoss_lacp.py:105:1: E302: expected 2 blank lines, found 1 ERROR: plugins/modules/arubaoss_lacp.py:113:1: W293: blank line contains whitespace ERROR: plugins/modules/arubaoss_lacp.py:114:5: E265: block comment should start with '# ' ERROR: plugins/modules/arubaoss_lacp.py:114:57: W291: trailing whitespace ERROR: plugins/modules/arubaoss_lacp.py:126:1: W293: blank line contains whitespace ERROR: plugins/modules/arubaoss_lacp.py:127:5: E265: block comment should start with '# ' ERROR: plugins/modules/arubaoss_lacp.py:128:5: E265: block comment should start with '# ' ERROR: plugins/modules/arubaoss_lacp.py:129:5: E265: block comment should start with '# ' ERROR: plugins/modules/arubaoss_lacp.py:137:5: E265: block comment should start with '# ' ERROR: plugins/modules/arubaoss_lacp.py:146:5: E125: continuation line with same indent as next logical line ERROR: plugins/modules/arubaoss_lacp.py:149:17: E125: continuation line with same indent as next logical line ERROR: plugins/modules/arubaoss_lacp.py:151:1: W293: blank line contains whitespace ERROR: plugins/modules/arubaoss_lacp.py:152:5: E265: block comment should start with '# ' ERROR: plugins/modules/arubaoss_lacp.py:153:5: E265: block comment should start with '# ' ERROR: plugins/modules/arubaoss_lacp.py:154:5: E265: block comment should start with '# ' ERROR: plugins/modules/arubaoss_lacp.py:163:5: E125: continuation line with same indent as next logical line ERROR: plugins/modules/arubaoss_lacp.py:170:13: E125: continuation line with same indent as next logical line ERROR: plugins/modules/arubaoss_lacp.py:173:5: E265: block comment should start with '# ' ERROR: plugins/modules/arubaoss_lacp.py:174:5: E265: block comment should start with '# ' ERROR: plugins/modules/arubaoss_lacp.py:177:15: E271: multiple spaces after keyword ERROR: plugins/modules/arubaoss_lacp.py:177:45: E271: multiple spaces after keyword ERROR: plugins/modules/arubaoss_lacp.py:179:5: E125: continuation line with same indent as next logical line ERROR: plugins/modules/arubaoss_lacp.py:180:22: E111: indentation is not a multiple of 4 ERROR: plugins/modules/arubaoss_lacp.py:180:22: E117: over-indented ERROR: plugins/modules/arubaoss_lacp.py:182:22: E127: continuation line over-indented for visual indent ERROR: plugins/modules/arubaoss_lacp.py:183:22: E111: indentation is not a multiple of 4 ERROR: plugins/modules/arubaoss_lacp.py:183:22: E117: over-indented ERROR: plugins/modules/arubaoss_lacp.py:184:1: W293: blank line contains whitespace ERROR: plugins/modules/arubaoss_lacp.py:185:5: E265: block comment should start with '# ' ERROR: plugins/modules/arubaoss_lacp.py:202:5: E265: block comment should start with '# ' ERROR: plugins/modules/arubaoss_lacp.py:204:10: E111: indentation is not a multiple of 4 ERROR: plugins/modules/arubaoss_lacp.py:204:10: E117: over-indented ERROR: plugins/modules/arubaoss_lacp.py:205:14: E111: indentation is not a multiple of 4 ERROR: plugins/modules/arubaoss_lacp.py:205:70: E231: missing whitespace after ',' ERROR: plugins/modules/arubaoss_lacp.py:208:66: E231: missing whitespace after ',' ERROR: plugins/modules/arubaoss_lacp.py:214:1: E302: expected 2 blank lines, found 1 ERROR: plugins/modules/arubaoss_lacp.py:220:32: E127: continuation line over-indented for visual indent ERROR: plugins/modules/arubaoss_lacp.py:233:1: W293: blank line contains whitespace ERROR: plugins/modules/arubaoss_lacp.py:234:5: E265: block comment should start with '# ' ERROR: plugins/modules/arubaoss_lacp.py:250:1: E302: expected 2 blank lines, found 1 ERROR: plugins/modules/arubaoss_lacp.py:256:1: W391: blank line at end of file01
ERROR: plugins/modules/arubaoss_lacp.py:178:35: ansible-format-automatic-specification: Format string contains automatic field numbering specification ERROR: plugins/modules/arubaoss_lacp.py:234:25: ansible-format-automatic-specification: Format string contains automatic field numbering specification
and update documentation
ERROR: plugins/modules/arubaoss_lacp.py:0:0: parameter-type-not-in-doc: Argument 'lacp' in argument_spec defines type as 'str' but documentation doesn't define type ERROR: plugins/modules/arubaoss_lacp.py:0:0: parameter-type-not-in-doc: Argument 'port_id' in argument_spec defines type as 'str' but documentation doesn't define type ERROR: plugins/modules/arubaoss_lacp.py:0:0: parameter-type-not-in-doc: Argument 'state' in argument_spec defines type as 'str' but documentation doesn't define type ERROR: plugins/modules/arubaoss_lacp.py:0:0: parameter-type-not-in-doc: Argument 'trunk_group' in argument_spec defines type as 'str' but documentation doesn't define type
need to semantic version and lacp module is add on 1.6.0
|
Hi @tchiapuziowong, can you review and merge if it is good ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.