Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COMPSGH-199: Update Dependencies to OasysGh #145

Merged
merged 11 commits into from
Dec 13, 2024
Merged

COMPSGH-199: Update Dependencies to OasysGh #145

merged 11 commits into from
Dec 13, 2024

Conversation

SandeepArup
Copy link
Contributor

@SandeepArup SandeepArup commented Dec 4, 2024

  • ComposUnitsHelper.IsEqual, because quantities now cannot be compared directly to number
  • Encoding was fixed
  • Removed SQLite.dll manual loading

@SandeepArup SandeepArup marked this pull request as ready for review December 6, 2024 14:53
@SandeepArup
Copy link
Contributor Author

CI

@SandeepArup SandeepArup requested a review from psarras December 6, 2024 15:51
DominikaLos

This comment was marked as outdated.

Copy link
Collaborator

@psarras psarras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's have a chat first. I think @DominikaLos has some minor comments and then we can merge it.

Compos/1_Beam/WebOpening/WebOpening.cs Show resolved Hide resolved
Compos/Helpers/SqlReader.cs Show resolved Hide resolved
Compos/Helpers/UnitsHelper.cs Show resolved Hide resolved
Compos/Helpers/UnitsHelper.cs Show resolved Hide resolved
@psarras psarras merged commit 011158c into main Dec 13, 2024
7 of 8 checks passed
@psarras psarras deleted the task/COMPSGH-199 branch December 13, 2024 09:51
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 58.97436% with 32 lines in your changes missing coverage. Please review.

Project coverage is 83.4%. Comparing base (77f56bd) to head (3570b6a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
Compos/Helpers/UnitsHelper.cs 19.3% 23 Missing and 2 partials ⚠️
Compos/2_Studs/StudSpecification.cs 50.0% 0 Missing and 2 partials ⚠️
...omposGH/Components/1_Beam/5_Quinary/CreateNotch.cs 33.3% 1 Missing and 1 partial ⚠️
Compos/1_Beam/WebOpening/WebOpening.cs 50.0% 0 Missing and 1 partial ⚠️
ComposGH/Parameters/1_Beam/BeamGoo.cs 0.0% 1 Missing ⚠️
ComposGH/Parameters/5_Member/MemberGoo.cs 0.0% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #145     +/-   ##
=======================================
+ Coverage   82.7%   83.4%   +0.7%     
=======================================
  Files        185     185             
  Lines      10951   10899     -52     
  Branches    1219    1208     -11     
=======================================
+ Hits        9062    9098     +36     
+ Misses      1614    1531     -83     
+ Partials     275     270      -5     
Files with missing lines Coverage Δ
Compos/0_File/ComposFile.cs 83.3% <100.0%> (+1.3%) ⬆️
Compos/1_Beam/BeamSection/BeamSection.cs 93.4% <100.0%> (+1.1%) ⬆️
Compos/2_Studs/StudGroupSpacing.cs 90.6% <100.0%> (ø)
Compos/3_Slab/SlabDimension/SlabDimension.cs 90.6% <100.0%> (ø)
Compos/5_Member/DesignCriteria/DeflectionLimit.cs 93.6% <100.0%> (ø)
..._CompositeProperties/CompositeSectionProperties.cs 100.0% <100.0%> (ø)
Compos/ComposUnits.cs 98.1% <100.0%> (ø)
Compos/Helpers/SqlReader.cs 75.7% <100.0%> (-0.5%) ⬇️
...ents/1_Beam/4_Quarternary/BeamSectionProperties.cs 98.2% <ø> (ø)
ComposGH/Helpers/ObjectExtension.cs 67.0% <100.0%> (+13.6%) ⬆️
... and 6 more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants