Fix deprecated session.add_torrent form to prevent crash

arvidn · Aug 8, 2021 · 0ec312e · 0ec312e
1 parent 8b386b6
commit 0ec312e
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/bindings/python/install_data/libtorrent/__init__.pyi b/bindings/python/install_data/libtorrent/__init__.pyi
@@ -1298,8 +1298,8 @@ class session:
     @overload
     def add_torrent(
         self,
-        _ti: torrent_info,
-        _save: _PathLike,
+        ti: torrent_info,
+        save: _PathLike,
         resume_data: Optional[_Entry] = ...,
         storage_mode: storage_mode_t = ...,
         paused: bool = ...,

diff --git a/bindings/python/src/session.cpp b/bindings/python/src/session.cpp
@@ -1176,6 +1176,8 @@ void bind_session()
         .def(
             "add_torrent", depr(&add_torrent_depr)
           , (
+                arg("ti"),
+                arg("save"),
                 arg("resume_data") = entry(),
                 arg("storage_mode") = storage_mode_sparse,
                 arg("paused") = false

diff --git a/bindings/python/tests/session_test.py b/bindings/python/tests/session_test.py
@@ -1094,7 +1094,6 @@ def setUp(self) -> None:
     def tearDown(self) -> None:
         lib.cleanup_with_windows_fix(self.dir, timeout=5)
 
-    @unittest.skip("https://github.com/arvidn/libtorrent/issues/5989")
     def test_old_style_with_wrong_args(self) -> None:
         with self.assertRaises(TypeError):
             self.session.add_torrent(  # type: ignore