Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: swaps deprecated container-structure-test plugin with a function… #946

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

FeryET
Copy link
Contributor

@FeryET FeryET commented Jan 11, 2024

Summary

This pull requests removes the old container-structure-test plugin and adds a new plugin that can install the package reliably in various environments.

Checklist

  • Format with scripts/format.bash
  • Test locally with scripts/test_plugin.bash --file plugins/<your_new_plugin_name>
  • Your plugin CI tests are green
  • Manual plugin tests using asdf plugin test command also succeeded in docker test environments.
    • Tip: use the plugin_test action from asdf-actions in your plugin CI

@FeryET FeryET requested a review from a team as a code owner January 11, 2024 21:30
Copy link
Contributor

@jthegedus jthegedus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jthegedus jthegedus merged commit dd4921a into asdf-vm:master Jan 12, 2024
4 checks passed
mbutov pushed a commit to mbutov/asdf-plugins that referenced this pull request May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants