Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add dynatrace-monaco plugin #951

Merged
merged 3 commits into from
Apr 1, 2024

Conversation

nsaputro
Copy link
Contributor

Summary

Description:

Checklist

  • Format with scripts/format.bash
  • Test locally with scripts/test_plugin.bash --file plugins/<your_new_plugin_name>
  • Your plugin CI tests are green
    • Tip: use the plugin_test action from asdf-actions in your plugin CI

@nsaputro nsaputro requested a review from a team as a code owner January 20, 2024 21:40
Copy link
Contributor

@jthegedus jthegedus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like this should be called dynatrace-monaco or something?

Copy link
Contributor

@jthegedus jthegedus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please rebase

@nsaputro nsaputro changed the title feat: add monaco plugin feat: add dynatrace-monaco plugin Apr 1, 2024
@nsaputro
Copy link
Contributor Author

nsaputro commented Apr 1, 2024

@jthegedus I have changed the name and rebased the the change. Please check

Copy link
Contributor

@jthegedus jthegedus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks mate!

@jthegedus jthegedus merged commit 8e311ee into asdf-vm:master Apr 1, 2024
5 checks passed
mbutov pushed a commit to mbutov/asdf-plugins that referenced this pull request May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants