Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add sui #981

Merged
merged 1 commit into from
Mar 31, 2024
Merged

feat: add sui #981

merged 1 commit into from
Mar 31, 2024

Conversation

caoer
Copy link
Contributor

@caoer caoer commented Mar 30, 2024

Summary

Description:

Checklist

  • Format with scripts/format.bash
  • Test locally with scripts/test_plugin.bash --file plugins/<your_new_plugin_name>
  • Your plugin CI tests are green
    • Tip: use the plugin_test action from asdf-actions in your plugin CI

@caoer caoer requested a review from a team as a code owner March 30, 2024 09:52
jthegedus
jthegedus approved these changes Mar 31, 2024
View reviewed changes
Copy link
Contributor

@jthegedus jthegedus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jthegedus jthegedus enabled auto-merge (squash) March 31, 2024 10:00
@jthegedus jthegedus disabled auto-merge March 31, 2024 10:00
jthegedus
jthegedus requested changes Mar 31, 2024
View reviewed changes
Copy link
Contributor

@jthegedus jthegedus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase

@caoer caoer requested a review from jthegedus March 31, 2024 10:05
jthegedus
jthegedus approved these changes Mar 31, 2024
View reviewed changes
Copy link
Contributor

@jthegedus jthegedus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, sorry about that, GitHub wouldn't let me force the squash-merge for some reason 🤷

@jthegedus jthegedus merged commit 4fc5f51 into asdf-vm:master Mar 31, 2024
4 checks passed
@caoer
Copy link
Contributor Author

caoer commented Mar 31, 2024

no problem. I think it's probably due to there is an edit on README in the upstream with same line as mine (what an odd thing..).

@caoer caoer deleted the feat/sui branch March 31, 2024 10:12
mbutov pushed a commit to mbutov/asdf-plugins that referenced this pull request May 6, 2024
@caoer
feat: add sui (asdf-vm#981)
f8f3ae7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jthegedus jthegedus jthegedus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caoer @jthegedus