fix: don't error if version already installed #1952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a version is already installed in all scenarios (i.e., asdf install, asdf install <tool>, asdf install <tool> <version>), don't exit with an error. Print the message that the tool is installed and do a clean exit, following the behavior before 0.16.0. Co-authored-by: Ruby Nealon <[email protected]>
ivanvc
force-pushed
the
ruby/fix-already-installed-return-code
branch
from
d73df13 to
0bea38b
Compare
|
cc. @Stratus3D |
|
Thank you @ivanvc ! 🙏🙇♀️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If a version is already installed in all scenarios (i.e.,
asdf install,asdf install [tool],asdf install [tool] [version]), don't exit with an error. Print the message that the tool is installed and do a clean exit, following the behavior before 0.16.0.Supersedes #1900.
Fixes #1893.
Other Information
Added unit tests and bats tests.