[flake8-unused-arguments] Add fixes for ARG001->ARG005
#10321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #10321 will not alter performanceComparing Summary
|
|
| /// Generic function to remove parameters in functions, methods or lambdas definitions. | ||
| /// | ||
| /// Supports the removal of parentheses when this is the only parameter left. | ||
| pub(crate) fn remove_parameter( |
There was a problem hiding this comment.
How does this differ from remove_argument?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds fixes for
unused-argumentsrules.The fix removes the unused arguments from the function/method definition.
The fix is marked as unsafe as removing a parameter changes the function definition, and we cannot access call sites to also remove the argument there.
The
remove_parameterfunction, analog toremove_argumentwas added. It is tested through the fix.The rule was a bit refactored: the
function,methodandcallfunctions were merged in a singlecheckfunctionTest Plan
New test cases were added to test with all parameter kinds.