[flake8-bugbear] Handle shadowing and scope in unused-loop-control-variable (B007)
#14122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylwil3
commented
Nov 6, 2024
Comment on lines
93
to
105
| let scope = &checker.semantic().current_scope(); | ||
| if checker | ||
| .semantic() | ||
| .binding(scope.get(name).unwrap()) | ||
| .references | ||
| .iter() | ||
| .map(|&refid| checker.semantic().reference(refid).range()) | ||
| .any(|refrange| { | ||
| stmt_for | ||
| .body | ||
| .iter() | ||
| .any(|stmt| stmt.range().contains_range(refrange)) | ||
| }) |
There was a problem hiding this comment.
If someone has a cleaner way of doing this I'd love to know!
|
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| B007 | 13 | 13 | 0 | 0 | 0 |
Linter (preview)
ℹ️ ecosystem check detected linter changes. (+13 -0 violations, +0 -0 fixes in 8 projects; 46 projects unchanged)
DisnakeDev/disnake (+1 -0 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview
+ disnake/ext/commands/core.py:991:13: B007 Loop control variable `name` not used within loop body
PlasmaPy/PlasmaPy (+2 -0 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview
+ tests/utils/decorators/test_checks.py:429:26: B007 Loop control variable `val` not used within loop body + tests/utils/decorators/test_validators.py:191:26: B007 Loop control variable `val` not used within loop body
apache/airflow (+5 -0 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview --select ALL
+ airflow/api_fastapi/core_api/routes/public/dag_run.py:128:20: B007 Loop control variable `attr_value` not used within loop body + airflow/serialization/serialized_objects.py:973:16: B007 Loop control variable `v` not used within loop body + providers/src/airflow/providers/google/cloud/hooks/bigquery.py:2299:32: B007 Loop control variable `param_default` not used within loop body + providers/src/airflow/providers/google/cloud/hooks/bigquery.py:3201:32: B007 Loop control variable `param_default` not used within loop body + providers/tests/amazon/aws/hooks/test_hooks_signature.py:104:9: B007 Loop control variable `k` not used within loop body
apache/superset (+1 -0 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview --select ALL
+ superset/commands/tag/create.py:91:23: B007 Loop control variable `obj_id` not used within loop body
ibis-project/ibis (+1 -0 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview
+ ibis/backends/sql/dialects.py:291:25: B007 Loop control variable `e` not used within loop body
milvus-io/pymilvus (+1 -0 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview
+ examples/collection.py:131:9: B007 Loop control variable `i` not used within loop body
pypa/pip (+1 -0 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview
+ src/pip/_internal/metadata/pkg_resources.py:215:17: B007 Loop control variable `name` not used within loop body
reflex-dev/reflex (+1 -0 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview
+ reflex/state.py:818:13: B007 Loop control variable `name` not used within loop body
Changes by rule (1 rules affected)
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| B007 | 13 | 13 | 0 | 0 | 0 |
|
Those ecosystem results look like they have a few false positives - let me add some more test cases for those and fix up the implementation. The issue appears to be that the control variables are explicitly deleted after or at the end of some loops, and the semantic model (correctly) removes the reference. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the logic employed to search for uses of the control variable within the loop body in order to account for shadowing and nested scope. This is achieved by using the semantic model to check whether there are any references to the binding of the control variable within the loop body.
Closes #14113 .