Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't build wheels for PyPy #218

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Don't build wheels for PyPy #218

merged 1 commit into from
Jul 15, 2024

Conversation

lpsinger
Copy link
Contributor

PyPy is probably not long for this world; see
mesonbuild/meson-python#626 (comment).

Fixes #216.

@lpsinger
Don't build wheels for PyPy
10035d7 
PyPy is probably not long for this world; see
mesonbuild/meson-python#626 (comment).

Fixes astropy#216.
@lpsinger lpsinger requested a review from pllim July 15, 2024 17:18
pllim
pllim approved these changes Jul 15, 2024
View reviewed changes
Copy link
Member

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust your judgement.

@pllim pllim requested a review from astrofrog July 15, 2024 17:52
@pllim pllim added the Build wheels Run the publish workflow label Jul 15, 2024
@pllim
Copy link
Member

pllim commented Jul 15, 2024

Oldest pin seems a little... old?

KeyError: "linkname 'astropy-3.2.3/CITATION' not found"
Collecting astropy==3.*
  Downloading astropy-3.2.3.tar.gz (8.0 MB)

@lpsinger
Copy link
Contributor Author

Oldest pin seems a little... old?

What version do you suggest?

@lpsinger lpsinger merged commit b04aae9 into astropy:main Jul 15, 2024
2 of 10 checks passed
@lpsinger lpsinger deleted the skip-pypy branch July 15, 2024 18:30
@pllim
Copy link
Member

pllim commented Jul 15, 2024

With LTS gone, I think anything older than v6 is not supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pllim pllim pllim approved these changes

@astrofrog astrofrog Awaiting requested review from astrofrog

Assignees
No one assigned
Labels
Build wheels Run the publish workflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BLD: pp39 wheels fail to build
2 participants
@lpsinger @pllim