-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Treat warnings in unit tests as errors #247
Conversation
938a295
to
faec1d8
Compare
On astropy, we just end up ignoring it... 😬 |
faec1d8
to
fb93f31
Compare
I tried to ignore it in my last commit, but it didn't work. Would you please take a look? |
fb93f31
to
6691d08
Compare
I wonder if the order matters. I have only used that list by listing "error" first, not last. |
6691d08
to
46857f5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #247 +/- ##
=======================================
Coverage 96.23% 96.23%
=======================================
Files 6 6
Lines 504 505 +1
=======================================
+ Hits 485 486 +1
Misses 19 19 ☔ View full report in Codecov by Sentry. |
That did it. Tests are passing now. |
Thanks! |
Fixes #240.