-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add policy for adding new role #460
base: main
Are you sure you want to change the base?
Conversation
Looks all good to me! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for drafting this! I think all the main points are covered.
In addition to my other comment I suggest to also modify the opening paragraph of adding-new-role-members.md
to mirror that of the new policy:
This document describes the process for adding new named roles. This
document is *not* about how people are added to the roles, which is covered under
[adding-new-role-members.md](https://github.com/astropy/astropy-project/blob/main/policies/adding-new-role-members.md).
This document describes the process for adding new people to named roles.
This document is *not* about how new roles are created, which is covered under
[adding-new-roles.md](https://github.com/astropy/astropy-project/blob/main/policies/adding-new-roles.md).
The process itself is overseen by the Coordination Committee.
For filling roles in the Coordination Committee, Ombudsperson, and Voting Members,
please also see the process laid out in
[APE0](https://github.com/astropy/astropy-APEs/blob/main/APE0.rst).
Otherwise I think the new file would not be linked from anywhere to be found.
In addition I'd also link it from the "Maintaining (and creating) roles" section in coco-operating-policies.md
, and perhaps both in fact directly from the README as well, since they now no longer may be initiated by CoCo only.
to add this new role. The PR must describe clearly why this role is essential to the Astropy | ||
Project and has clear description of associated responsibilities. If this role has sub-roles, | ||
those must be clarified as well in the same manner. This new role must be declared Unfilled | ||
for now (separation of concerns). This new role cannot duplicate any existing roles. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This raises the question how new roles may overlap with existing ones. We probably don't want to simply infringe on those roles' responsibilities, but there can also be legit cases to split the tasks of one roles to several new ones.
Perhaps add something like
If the new role touches or modifies the responsibilities of existing roles, those roles, and how they are affected by the proposed new role, shall also be named.
May also open the question of a policy for removing roles in general.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As for removing roles, you mean the assignments to a role, or the role itself, or both? Please clarify at #462 . Thanks!
@dhomeier , on your comment about README, I looked at both README under policies and also root level, but I cannot find any relevant text to update. Can you please clarify that request? Thanks! |
That's exactly the point; at present those files would only be found when skimming through the repo or the CoCo operating procedures, where a project member not on CoCo may not necessarily look. |
I feel like the README request is out of scope here. This PR should be just about the policy of adding new role. Therefore, I opened a follow-up issue here instead. Hope that is enough for now. Thanks! |
I also found a mistake and corrected here: |
(Ooops looks like I put wrong link in my commit message, so we should squash it out on merge.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, enough to update the existing links here, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fix #457
Also see https://groups.google.com/g/astropy-dev/c/f3nHkLonlfA