Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add policy for adding new role #460

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions policies/adding-new-role-members.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
This document describes the process for adding new people to named roles.
This document describes the process for adding new people to named roles. This
document is *not* about new roles are added, which is covered under
[adding-new-roles.md](https://github.com/astropy/astropy-project/blob/main/policies/adding-new-roles.md).

For roles related to CoCo, Ombudsperson, and Voting Members,
The process itself is overseen by the Astropy Coordination Committee.
For roles related to Astropy Coordination Committee, Ombudsperson, and Voting Members,
please also see the process laid out in
[APE0](https://github.com/astropy/astropy-APEs/blob/main/APE0.rst).

Expand Down Expand Up @@ -34,4 +37,4 @@ The process is:
8. The nominee receives the necessary GitHub or other permissions for the new role.
9. The nominee gets added to the astropy-core-maintainers mailing list.
10. The Coordination Committee member sends a confirmation message to the nominee
to complete the process.
to complete the process.
25 changes: 25 additions & 0 deletions policies/adding-new-roles.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
This document describes the process for adding new named roles. This
document is *not* about how people are added to the roles, which is covered under
[adding-new-role-members.md](https://github.com/astropy/astropy-project/blob/main/policies/adding-new-role-members.md).

The process is:

1. A voting member or maintainer in a related role, after consulting with other members in
related roles, opens a PR to [astropy.github.com](https://github.com/astropy/astropy.github.com)
to add this new role. The PR must describe clearly why this role is essential to the Astropy
Project and has clear description of associated responsibilities. If this role has sub-roles,
those must be clarified as well in the same manner. This new role must be declared Unfilled
for now (separation of concerns). This new role cannot duplicate any existing roles.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This raises the question how new roles may overlap with existing ones. We probably don't want to simply infringe on those roles' responsibilities, but there can also be legit cases to split the tasks of one roles to several new ones.

Perhaps add something like

If the new role touches or modifies the responsibilities of existing roles, those roles, and how they are affected by the proposed new role, shall also be named.

May also open the question of a policy for removing roles in general.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As for removing roles, you mean the assignments to a role, or the role itself, or both? Please clarify at #462 . Thanks!

If the new role touches or modifies the responsibilities of existing roles, those roles,
and how they are affected by the proposed new role, shall also be clarified.
2. The PR author sends out a notice of this PR to astropy-dev mailing list, with cc to the
Coordination Committee, starting a two-week clock on the feedback period
[as required by APE0](https://github.com/astropy/astropy-APEs/blob/main/APE0.rst#responsibilities-and-authority).
3. Once the two week period has elapsed, the Coordination Committee makes a
final decision based on any feedback.
4. If the new role is confirmed, the PR is merged. Otherwise, it is closed without merge.
5. The Coordination Committee member sends an update to the astropy-dev notice
with an update, regardless of the decision.
6. If new role is accepted in Step 4, proceed to
[adding-new-role-members.md](https://github.com/astropy/astropy-project/blob/main/policies/adding-new-role-members.md)
for the next steps.
4 changes: 3 additions & 1 deletion policies/coco-operating-policies.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,12 @@ This document instead is meant to describe procedure, and where necessary,
policy, for how the CoCo operates.

## Processes and Responsibilities

- The primary responsibilities, election, and philosophy of the CoCo are described in
[APE0](https://github.com/astropy/astropy-APEs/blob/main/APE0.rst). That content is not
duplicated here.
- Maintaining roles. [[Process]](https://github.com/astropy/astropy-project/blob/main/policies/adding-new-role-members.md)
- Maintaining role categories. [[Process]](https://github.com/astropy/astropy-project/blob/main/policies/adding-new-roles.md)
- Maintaining role assignments. [[Process]](https://github.com/astropy/astropy-project/blob/main/policies/adding-new-role-members.md)
- Reviewing and finalizing Astropy Proposals for Enhancement (APEs). [[Process]](https://github.com/astropy/astropy-APEs#finalizing-apes)

## Meeting Details
Expand Down