-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add policy for adding new role #460
Open
pllim
wants to merge
3
commits into
astropy:main
Choose a base branch
from
pllim:add-new-role
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+34
−4
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
This document describes the process for adding new named roles. This | ||
document is *not* about how people are added to the roles, which is covered under | ||
[adding-new-role-members.md](https://github.com/astropy/astropy-project/blob/main/policies/adding-new-role-members.md). | ||
|
||
The process is: | ||
|
||
1. A voting member or maintainer in a related role, after consulting with other members in | ||
related roles, opens a PR to [astropy.github.com](https://github.com/astropy/astropy.github.com) | ||
to add this new role. The PR must describe clearly why this role is essential to the Astropy | ||
Project and has clear description of associated responsibilities. If this role has sub-roles, | ||
those must be clarified as well in the same manner. This new role must be declared Unfilled | ||
for now (separation of concerns). This new role cannot duplicate any existing roles. | ||
If the new role touches or modifies the responsibilities of existing roles, those roles, | ||
and how they are affected by the proposed new role, shall also be clarified. | ||
2. The PR author sends out a notice of this PR to astropy-dev mailing list, with cc to the | ||
Coordination Committee, starting a two-week clock on the feedback period | ||
[as required by APE0](https://github.com/astropy/astropy-APEs/blob/main/APE0.rst#responsibilities-and-authority). | ||
3. Once the two week period has elapsed, the Coordination Committee makes a | ||
final decision based on any feedback. | ||
4. If the new role is confirmed, the PR is merged. Otherwise, it is closed without merge. | ||
5. The Coordination Committee member sends an update to the astropy-dev notice | ||
with an update, regardless of the decision. | ||
6. If new role is accepted in Step 4, proceed to | ||
[adding-new-role-members.md](https://github.com/astropy/astropy-project/blob/main/policies/adding-new-role-members.md) | ||
for the next steps. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This raises the question how new roles may overlap with existing ones. We probably don't want to simply infringe on those roles' responsibilities, but there can also be legit cases to split the tasks of one roles to several new ones.
Perhaps add something like
May also open the question of a policy for removing roles in general.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As for removing roles, you mean the assignments to a role, or the role itself, or both? Please clarify at #462 . Thanks!