feat: add cypress #386
Open
feat: add cypress #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into feat/add-testing-framework
… into feat/add-testing-framework
… into feat/add-testing-framework
Co-authored-by: V Thulisile Sibanda <[email protected]>%0ACo-authored-by: asyncapi-bot <[email protected]>%0ACo-authored-by: prashantrai-30 <[email protected]>
Co-authored-by: acethecreator <[email protected]>
* initial commit for CFP and speakers form * changes to the form * removed comments * added example env * changes to apply btn * configured the speakers register API * changed path for CFP * url correction * added Online conference in the Navbar * Made CFP banner and details json dependent * update cfp page * Update dates * Update eventDetails.js * test commit * configured to build * temp changes to form * changes to form style * changed email message * changed the email message * changed cfp dates * changes to cfp css * changes to online page * deleted useless components * Update README.md * Update README.md * added speakers guideline component * changes to guidelines * changed carousel image * changes for production * changes to env names * testing changes * test 2 * test 3 * test 4 * test 5 * test 6 * changes to netlify.toml * test 1 * test 2 * test 3 * test 4 --------- Co-authored-by: asyncapi-bot <[email protected]> Co-authored-by: V Thulisile Sibanda <[email protected]> Co-authored-by: Ace <[email protected]> Co-authored-by: acethecreator <[email protected]>
This reverts commit 066c265.
* added online cfp form * testing different toml configuration * ehanced config * testing new config * fixed typo * fixed cfp date
Co-authored-by: Cody's Dad <[email protected]>
ashmit-coder
requested review from
AceTheCreator,
thulieblack and
Mayaleeeee
as code owners
✅ Deploy Preview for peaceful-ramanujan-288045 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
… into feat/add-testing-framework
… into feat/add-testing-framework
…t-coder/conference-website into feat/add-testing-framework
… into feat/add-testing-framework
… into feat/add-testing-framework
… into feat/add-testing-framework
… into feat/add-testing-framework
|
/ptal |
|
@AceTheCreator @thulieblack @Mayaleeeee Please take a look at this PR. Thanks! 👋 |
Comment on lines
+7
to
+9
| push: | ||
| branches: | ||
| - master |
There was a problem hiding this comment.
I think we only need to run the tests on the incoming changes via a new pull request, so we don't need this part
There was a problem hiding this comment.
Sometimes there are direct pushes by the admins, so I guess lets keep it?
Comment on lines
+23
to
+27
| - name: Cypress run | ||
| uses: cypress-io/github-action@v6 | ||
| with: | ||
| build: npm run build | ||
| start: npm start |
There was a problem hiding this comment.
Don't know much about the cypress testing part. Better to follow the official docs and figure it out.
There was a problem hiding this comment.
Yeah I did write it from the official docs. Do have a look at them if you want.
AnimeshKumar923
suggested changes
Oct 20, 2024
There was a problem hiding this comment.
I've reviewed it to the best of my knowledge. Let me know what you think @ashmit-coder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s)
Resolves #385