-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 2.7.0 #141
base: master
Are you sure you want to change the base?
feat: 2.7.0 #141
Conversation
fix: #133 Support IntelliJ IDEA 2024.3 (build 243)
Noting for the record the following errors and warnings occurred with
That said, the build still "succeeded" |
Gradle Wrapper version needs to be updated to 8.11.1
|
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments on code
|
|
To match Kotlin JVM version in `build.gradle.kts`
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two things:
-
COMPATIBILITY.md
apparently hasn't been updated since version2.2.0
-
I can't figure out how to run the code tests.
If I run ./gradlew check --scan
, it fails complaining that org.junit.vintage:junit-vintage-engine
depends on a too-old version of junit
.
Same result if I try within IntelliJ IDEA to run a single test -- say AsyncAPIJsonSchemaProviderTest's test - injects correctly
test -- same error
If I comment-out that vintage
line in build.gradle.kts
-- and then run ./gradlew check --scan
...ZERO tests are run.
If now -- with the vintage
line commented-out -- I try within IntelliJ IDEA to run a single test -- say AsyncAPIJsonSchemaProviderTest's test - injects correctly
test -- it complains:
No matching tests found in any candidate test task.
Requested tests:
Test pattern com.asyncapi.plugin.idea._core.AsyncAPIJsonSchemaProviderTest.test - injects correctly in task :test
What am I doing wrong?
Added
Fixed