-
-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: adds C++ constraint docs #1696
docs: adds C++ constraint docs #1696
Conversation
✅ Deploy Preview for modelina canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
Pull Request Test Coverage Report for Build 7340979409
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just got one comment 💪
docs/constraints/Cplusplus.md
Outdated
|NO_NUMBER_START_CHAR|No numbers as starting characters|Default behavior is pre pending `number_` in front of the first character| | ||
|NO_EMPTY_VALUE|No empty values|Default behavior is to use `empty` as name. | | ||
|NO_RESERVED_KEYWORDS|No reserved keywords|C++ has a list of reserved keywords ([see the full list here](../../src/generators/cplusplus/Constants.ts))| | ||
|NAMING_FORMATTER|Must be formatted equally|Model name is formatted using pascal case| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The model namings use toSnakeCase
function not pascal case, please double check that the implementation and docs (for all the constraints) are matching: https://github.com/asyncapi/modelina/blob/cbf55179f37adaa9b67564b2fc022615d7c66095/src/generators/cplusplus/constrainer/EnumConstrainer.ts#L42C35-L42C46
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
@jonaslagoni Made some changes. Notice that only
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, thanks @ankur0904 🤙
hey, @jonaslagoni can I become part of a contributor for doc, maintenance? |
@ankur0904 docs for sure, however maintenance is for those who are code owners 😄 If you want to become a codeowner read more here: #1148 |
@all-contributors please add @ankur0904 for docs |
I've put up a pull request to add @ankur0904! 🎉 |
Thanks @jonaslagoni |
🎉 This PR is included in version 3.0.0-next.11 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 2.1.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Adds the missing
C++
constraint docs.Related Issue
Fix #1671