Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove double None from Pydantic preset #2181

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

black-snow
Copy link

@black-snow black-snow commented Feb 14, 2025

@jonaslagoni not sure if you're the original author - could you review this? See #2174

Fixes #2174

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

Copy link

netlify bot commented Feb 14, 2025

Deploy Preview for modelina canceled.

Name Link
🔨 Latest commit ad62d8f
🔍 Latest deploy log https://app.netlify.com/sites/modelina/deploys/67b0624fb0b858000849b55d

@black-snow black-snow changed the title remove double None from Pydantic preset fix: remove double None from Pydantic preset Feb 14, 2025
Copy link
Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @black-snow

@jonaslagoni
Copy link
Member

@black-snow remember to update the examples npm run test:examples -- -u

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] generates broken Python code, default kwarg repeated
2 participants