-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ep/ensemble calc #537
Open
jnsLs
wants to merge
61
commits into
master
Choose a base branch
from
ep/ensemble_calc
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Ep/ensemble calc #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…chwise_opt_w_calc
Batchwise optimizer and ensemble NN and calculator are implemented
…g/schnetpack into jl/batchwise-and-ensemble
Sh jl/update lammps
Mg/docs tut05
Jl/batchwise and ensemble
Add ensemble average functionality with user defined and provided uncertainty measurement Test Ensemble Calculator with ASE Optimitation and ASE MD code Test Ensemble Calculator with Batchwise optimization Results from Batchwise Optimization with Batchwise Calculator and Batchwise Optimitation with Ensemble Calculator differ on average 0.01 % Comparision by RMSD of atomic positions
update testing batchwise opt with ensemble
ASE base calculator with this the ase gui error does not occur
ensemble calc
simple ensemble average adapted to current implementation
Adapting ensemble calc average strategy class
default ensemble_strategy add docstring
# 537 regarding
…ecified separately
epens94
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replaced ethanol model:
- old model was not compatible with CastTo64 transform anymore
- new model is trained on rmd17 instead of md17
now implemented:
SpkCalculator
SpkEnsembleCalculator <- inherits from SpkCalculator
BatchwiseCalculator <- inherits from SpkCalculator
BatchwiseEnsembleCalculator <- inherits from SpkEnsembleCalculator
SimpleEnsembleAverage (example for a particular average strategy)
the calculators have two new methods (to allow for more modular classes):
_collect_results <-- calculates model outputs and converts property units
_ase_specific_output_format <-- for individual structures this converts energy output to scalar value, for batches of structures it keeps the output in array form
updated batchwise optimization howto jupyter notebook --> 01_howto_batchwise_relaxations.ipynb
added howto_ensemble_calculations jupyter notebook --> 02_howto_ensemble_calculator