Add comments to sendcloud presign string formation logic

authgear · Sep 24, 2024 · 5e2df93 · 5e2df93
1 parent 081fbbd
commit 5e2df93
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/pkg/lib/infra/sms/sendcloud/models/send.go b/pkg/lib/infra/sms/sendcloud/models/send.go
@@ -47,6 +47,10 @@ func NewSendRequest(
 
 func (r *SendRequest) Presign() string {
 	vars, _ := json.Marshal(r.vars)
+
+	// According to the [doc](https://www.sendcloud.net/doc/sms/),
+	// - The keys should be arranged alphabetically
+	// - The values no need to be url encoded
 	return strings.Join([]string{
 		fmt.Sprintf("msgType=%v", r.msgType),
 		fmt.Sprintf("phone=%v", strings.Join(r.phone, ",")),