Make plus hyphens regexp a module private variable

authgear · Sep 24, 2024 · e0d60a0 · e0d60a0
1 parent ad361f2
commit e0d60a0
Showing 1 changed file with 9 additions and 3 deletions.
diff --git a/pkg/lib/infra/sms/accessyou.go b/pkg/lib/infra/sms/accessyou.go
@@ -42,10 +42,16 @@ func NewAccessYouClient(
 	}
 }
 
+var plusHyphensRegexp = regexp.MustCompile(`[\+\-]+`)
+
+func fixPhoneNumber(phoneNumber string) string {
+	// Access you phone number should have no + and -
+	return plusHyphensRegexp.ReplaceAllString(phoneNumber, "")
+}
+
 func (n *AccessYouClient) Send(options *SendOptions) (*SendResult, error) {
-	// Access you phone number should have no +
-	m1 := regexp.MustCompile(`[\+\-]+`)
-	to := m1.ReplaceAllString(string(options.To), "")
+	to := fixPhoneNumber(string(options.To))
+
 	respData, sendSMSResponse, err := apis.SendSMS(
 		n.Client,
 		n.BaseUrl,